Vote #67187: Member role forms in project settings are not hidden after member added - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #67187

完了

Member role forms in project settings are not hidden after member added

Admin Redmine さんがほぼ2年前に追加. ほぼ2年前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

UI_10

対象バージョン:

0.9.5_19

開始日:

2010/05/06

期日:

進捗率:

100%

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/5452

category_id:

version_id:

issue_org_id:

5452

author_id:

11874

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

Member role forms in project settings should be hidden by default.
And we click [edit] button to see them.
But if I add some member to a project, all member role forms are shown.
So I have to click [cancel] button one by one to hide them.

It seems that the behavior was changed after the fix for #4852 ( r3483 ).
Because the load event handler bellow is not called after member added.

Event.observe(window, 'load', function() {
  $$('.hol').each(function(el) {
    el.hide();
    });
});

journals

I have also had that problem on at least one of my installations. I'll try to go through all of them and post the version numbers.
--------------------------------------------------------------------------------

See patches attached for application.js and _members.rhtml

The name of the function hideRoles could be change if not appropriate.
--------------------------------------------------------------------------------
The other file
--------------------------------------------------------------------------------
Alain Gandon wrote:
> See patches attached for application.js and _members.rhtml
>
> The name of the function hideRoles could be change if not appropriate.

Thanks for your cooperation.
The patch works fine.
But I noticed that there still remains some code to be fixed.
So I updated your patch.
--------------------------------------------------------------------------------
> But I noticed that there still remains some code to be fixed.

Member role forms are shown not only after member added, but also after member deleted and member role changed.

--------------------------------------------------------------------------------
Updated the patch to reflect the current trunk.
--------------------------------------------------------------------------------
Fixed in r3784. I did it a little differently and had the RJS in the MembersController send @hideOnLoad()@ to the page itself. Thank you for the contribution.
--------------------------------------------------------------------------------
Merged to 0.9-stable for release.
--------------------------------------------------------------------------------