Vote #74412: SCM annotate with non ASCII author - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #74412

完了

SCM annotate with non ASCII author

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

SCM_3

対象バージョン:

2.3.4_74

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/14931

category_id:

version_id:

issue_org_id:

14931

author_id:

85924

assigned_to_id:

11192

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

If author field in git commit contains UTF8 symbols, Repository Annotate page crashes with the following messages in the production.log:

Started GET "/projects/p175b304/repository/revisions/master/annotate/crash.c" for 192.168.1.10 at 2013-09-17 01:58:02 +0300
Processing by RepositoriesController#annotate as HTML
  Parameters: {"id"=>"p175b304", "rev"=>"master", "path"=>"crash.c"}
  Current user: admin (id=1)
  Rendered repositories/_navigation.html.erb (58.6ms)
  Rendered repositories/_breadcrumbs.html.erb (4.0ms)
  Rendered repositories/_link_to_functions.html.erb (3.7ms)
  Rendered repositories/annotate.html.erb within layouts/base (91.9ms)
Completed 500 Internal Server Error in 329ms

ActionView::Template::Error (incompatible character encodings: UTF-8 and ASCII-8BIT):
    55:         <%= yield :sidebar %>
    56:         <%= view_layouts_base_sidebar_hook_response %>
    57:

58: 59:

60: <%= render_flash_messages %> 61: <%= yield %> app/views/layouts/base.html.erb:58:in `_app_views_layouts_base_html_erb___1550060124232729327_17288283060'

Atatched patch fixed the problem for me, but I'm not familiar with ruby/rails, so I'm not sure if it is a correct solution.

Environment:
Redmine version 2.3.2.stable
Ruby version 1.9.3-p448 (2013-06-27) [amd64-freebsd9]
Rails version 3.2.13
Environment production
Database adapter SQLite
Redmine plugins:
no plugin installed

journals

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
This page returns 500 error.

https://www.chiliproject.org/projects/chiliproject/repository/revisions/984c9ffa2777b08bd327098c680ae2904fdfd0bd/annotate/app/models/document.rb
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Fixed in trunk and 2.3-stable.
--------------------------------------------------------------------------------