Vote #75811
完了Show warning when attempting to attach more than the allowed number of attachments
0%
説明
I was just notified by an employee of mine that my ticket was missing some of the attached files that should have been there. I thought I had merely forgot to attach them; however, upon repeating my edit due to needing to remake all the files I learned that redmine has a hard limit of 10 files attached per edit.
Although I'm not sure why this limit exists (I'll be adding another issue to make this a setting or remove it) redmine should definitely alert the end user to the limit both beforehand such as like the the text for max file size is displayed as well as after an attempt to add more than 10 files is added (javascript alert box or something similar).
This is related to issue #8579
This is the code in question: source:/trunk/public/javascripts/attachments.js#L6
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
After adding the eleventh file, I attached a patch that gives a javascript alert like the image below.
!{width: 70%; border: 1px solid #ccc}ScreenShot.png!
max-number-of-files-message:
<pre>
This file cannot be uploaded because the maximum number of files that can be attached at the same time has been reached.
</pre>
I'm not a native English speaker, so I'd like someone to review the "max-number-of-files-message".
--------------------------------------------------------------------------------
I changed the message.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
@Marius BALTEANU and @Bernhard Rohloff corrected the English sentence, so I updated the patch based on that.
--------------------------------------------------------------------------------
Setting the target version to 4.2.0.
--------------------------------------------------------------------------------
Committed the patch. Thank you for improving Redmine.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
With this change, you will now be alerted three times when you attach 13 files at the same time. The alert will be repeated as many times as the limit of 10 is exceeded. ( Related comment: https://www.redmine.org/issues/30776#note-7 )
!alerts-appear-multiple-times.gif!
I think one alerts is enough, so I'll attach a patch to fix it.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Mizuki ISHIKAWA wrote:
> With this change, you will now be alerted three times when you attach 13 files at the same time. The alert will be repeated as many times as the limit of 10 is exceeded. ( Related comment: https://www.redmine.org/issues/30776#note-7 )
> !alerts-appear-multiple-times.gif!
Fixed in r20711. Thank you.
--------------------------------------------------------------------------------
related_issues
relates,New,18556,Add ability to configure limit of attachments at once
duplicates,Closed,18642,Limited number of simultanous file uploads