Vote #79928
完了TimelogTest#test_default_query_setting fails depending on the language of the browser
0%
説明
The test fails in some environment.
Failure: TimelogTest#test_default_query_setting [/Users/maeda/redmines/redmine-trunk/test/system/timelog_test.rb:82]: Expected false to be truthy. bin/rails test test/system/timelog_test.rb:77
This is because the test expects the current language is always English, but actually the language is auto-selected depending on the test environment. For example, Japanese is the default language in my environment. The test looks for a table header "Comment" and fails because there is a Japanese text "コメント" instead of "Comment".
!{width: 1024px; border: 1px solid #ccc;}.test_default_query_setting-fails@2x.png!
journals
Forcing the English language for anonymous users fixes the issue.
<pre><code class="diff">
diff --git a/test/system/timelog_test.rb b/test/system/timelog_test.rb
index 58886c050..7c637d6cd 100644
--- a/test/system/timelog_test.rb
+++ b/test/system/timelog_test.rb
@@ -75,11 +75,13 @@ class TimelogTest < ApplicationSystemTestCase
end
def test_default_query_setting
- # Display the list with the default settings
- visit '/time_entries'
- within 'table.time-entries thead' do
- assert page.has_no_link?('Tracker')
- assert page.has_text?('Comment')
+ with_settings :default_language => 'en', :force_default_language_for_anonymous => '1' do
+ # Display the list with the default settings
+ visit '/time_entries'
+ within 'table.time-entries thead' do
+ assert page.has_no_link?('Tracker')
+ assert page.has_text?('Comment')
+ end
end
# Change the default columns
</code></pre>
--------------------------------------------------------------------------------
Committed.
--------------------------------------------------------------------------------
Admin Redmine さんが3年以上前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 4.1.0_127 にセット