The correct issue title should : Formating toolbar : new color tools

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Here is the patch, and the 2 new images to put in *public/images/jstoolbar/*

This patch does not manage the case when we want background an text color at the same time.

--------------------------------------------------------------------------------
!{border: 1px solid}text_color.png!

!{border: 1px solid}text_color_and_background.png!
--------------------------------------------------------------------------------
Here is a new patch managing some mixed cases of color / background color.

Detects if selected text already contains a css tag.
* If tag contains the css we want, replace the color.
* If not, add the css to the other tags.
--------------------------------------------------------------------------------
Fixed previous patch.

Managed more mixed color / background color tags.

@Go thanks to have renamed the issue subject
--------------------------------------------------------------------------------
The patch seems supports only Textile but Markdown. Since Redmine supports both Textile and Markdown, I think the patch should also support Markdown.
--------------------------------------------------------------------------------
Hi, I am going to provide the patch for <span style color="green">Markdown</span>

Now that %{color:green}Textile is OK%.
--------------------------------------------------------------------------------
Hi, here is a patch to apply after the previous patch.
It includes *code refactoring* and *Markdown support*.
For Markdown, *html filter* must be disabled (C.f. http://www.redmine.org/boards/2/topics/56096?r=57052#message-57052).

One remark about responsive design, the tools icons div has no horizontal scrollbar enabled. Thus some icons on the right can disappear with smaller window size.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Thanks Go to have proposed this for the next major release.
--------------------------------------------------------------------------------
Two latest patches don't work without:
<pre><code class="diff">
Index: public/javascripts/jstoolbar/jstoolbar.js
===================================================================
--- public/javascripts/jstoolbar/jstoolbar.js (date 1568621686000)
+++ public/javascripts/jstoolbar/jstoolbar.js (date 1568636186385)
@@ -373,12 +373,12 @@
}

if (typeof(fn) == 'function') {
- res = (sel) ? fn.call(this,sel) : fn('');
+ res = (sel) ? fn.call(this,sel,prefix,suffix) : fn('');
} else {
res = (sel) ? sel : '';
}

- subst = prefix + res + suffix;
+ subst = res;

if (typeof(document["selection"]) != "undefined") {
document.selection.createRange().text = subst;
</code></pre>

Am I missing something? That change have never been mentioned in any of related patches.
--------------------------------------------------------------------------------
Hello, you're right changes to jstoolbar.js were missing.

Here is the full SVN diff for this file.
--------------------------------------------------------------------------------