Vote #80118
未完了Test fails if trailing whitespaces are removed
ステータス:
New
優先度:
通常
担当者:
-
カテゴリ:
Code cleanup/refactoring_30
対象バージョン:
-
開始日:
2022/05/09
期日:
進捗率:
0%
予定工数:
Redmineorg_URL:
category_id:
30
version_id:
0
issue_org_id:
31507
author_id:
107353
assigned_to_id:
0
comments:
3
status_id:
1
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
説明
The test @test_partials_with_html_entities@ fails if the trailing whitespaces are removed. The attached patch can be used to reproduce the below problem:
notroot@eb7d0b73147d:/work$ ruby test/unit/lib/redmine/unified_diff_test.rb -n test_partials_with_html_entities
DEPRECATION WARNING: `secrets.secret_token` is deprecated in favor of `secret_key_base` and will be removed in Rails 6.0. (called from at /work/config/environment.rb:16)
Run options: -n test_partials_with_html_entities --seed 55482
# Running:
E
Error:
Redmine::UnifiedDiffTest#test_partials_with_html_entities:
NoMethodError: undefined method `html_line_left' for nil:NilClass
test/unit/lib/redmine/unified_diff_test.rb:106:in `test_partials_with_html_entities'
bin/rails test test/unit/lib/redmine/unified_diff_test.rb:92
I wasn't able to fix the test without changing the diff, any solution is welcome.
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Here is my patch. I could not think of any other solution.
--------------------------------------------------------------------------------
related_issues
relates,Closed,31506,Remove trailing whitespaces
いいね!0