プロジェクト

全般

プロフィール

Vote #80843

未完了

hook call "view_layouts_base_body_bottom" Inserts content below the viewport

Admin Redmine さんが約4年前に追加. ほぼ4年前に更新.

ステータス:
Confirmed
優先度:
通常
担当者:
-
カテゴリ:
Plugin API_20
対象バージョン:
-
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
20
version_id:
0
issue_org_id:
33374
author_id:
457707
assigned_to_id:
0
comments:
2
status_id:
9
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
160
ステータス-->[Confirmed]

説明

The content added via the "view_layouts_base_body_bottom" Hook is generated outside of any wrapper object.
With r18427 the size of the wrapper object is set to 100% of the viewport height.
As "view_layouts_base_body_bottom" places content outside of that wrapper, that content is now displayed outside of the viewport.
A possible fix could be placing the

<%= call_hook :view_layouts_base_body_bottom %>

line within the wrapper object like this

  
  <%= call_hook :view_layouts_base_body_bottom %>

journals

Forgot to mention the file for the possible fix:
@app/views/layouts/base.html.erb@
--------------------------------------------------------------------------------
I have confirmed that a user has to scroll down to see the content inserted with view_layouts_base_body_bottom as reported by Oliver Köhler.

But I am not sure whether moving the position of view_layouts_base_body_bottom is the best solution because the change makes an inconsistency. The inconsistency is that the view_layouts_base_top is currently placed right after the <body>, but the view_layouts_base_bottom will no longer be placed right before the </body> after applying the fix.

Maybe fixing this by somehow updating the CSS is better?
--------------------------------------------------------------------------------

Admin Redmine さんがほぼ4年前に更新

  • カテゴリPlugin API_20 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0