プロジェクト

全般

プロフィール

Vote #62200

未完了

Textilization of Documents, News and Timelog-entry comments

Admin Redmine さんがほぼ2年前に追加. ほぼ2年前に更新.

ステータス:
New
優先度:
通常
担当者:
-
カテゴリ:
Text formatting_26
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
26
version_id:
23
issue_org_id:
202
author_id:
62
assigned_to_id:
0
comments:
18
status_id:
1
tracker_id:
2
plus1:
2
affected_version:
closed_on:
affected_version_id:
ステータス-->[New]

説明

I've noticed another missing textilization:

Under projects/list_documents page, documents are listed with
a preview of their descriptions. However, the descriptions are
not textilized. When the description is shown under the documents/show
page, it is correctly textilized.


journals

Here's another one... seems like there's no reason the news
summary shouldn't also be textilized. (patch included)
--------------------------------------------------------------------------------
Just a bump on the issue. Plus is seems slightly related to issue #3740.
--------------------------------------------------------------------------------
Changed subject only.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Warren Harris wrote:
> [...] When the description is shown under the documents/show
> page, it is correctly textilized [...]

Except that syntax-highlighting isn't working in that specific case: see issue #3740.
--------------------------------------------------------------------------------
I'll make a summary of several different changes regarding proposals to render content as being "textilized":

1. I'll start with the initial request: At the documents page (at http://host.domain.tld/projects/projectfoo/documents) documents are listed with a preview of their descriptions. However, the descriptions are not textilized.
When the description is shown under the documents/show page (at http://host.domain.tld/documents/1), it is correctly textilized.

(patch; attachment:textilize-document-description_r3084.patch)

2. Lateron in the journal of this issue the textilisation of the news *summary* is also proposed and patched.

(patch; attachment:textilize-news-summary_r3084.patch)

3. I've now also merged issue #221 into this issue. It's basically a simple request to render the timelog-entry comments also textilized.

(patch; attachment:textilize-timelog-entry-comment_r3084.patch)

I've rebased all three patches against the latest trunk and attached them to this issue. I'll close/update issue #221 as being a (partial) duplicate of this issue (patch #221 does some more then what the issue's description says, which is only textilisation of the timelog-comment).

Can a Redmine Lead decide which of the patches will be implemented (in future) and decline the ones that aren't get integrated?
--------------------------------------------------------------------------------
Mischa The Evil wrote:
> [...] several different changes regarding proposals to render content as being "textilized":
>
> 1. [...] (patch; attachment:textilize-document-description_r3084.patch) [...]
>
> 2. [...] (patch; attachment:textilize-news-summary_r3084.patch [...]
>
> 3. [...] (patch; attachment:textilize-timelog-entry-comment_r3084.patch [...]
>
> [...]
>
> Can a Redmine Lead decide which of the patches will be implemented (in future) and decline the ones that aren't get integrated?

My personal proposal would be to only merge the patch for number 3. That one seems to provide the most useable UI-enhancement with a small change without any unwanted side-effects.
Number 2 seems to has a slight side-effect on the project-overview block and the news index view where trailing new-lines are added. Number 1 seems a good start considering related issue #3740 but therefor also seems to have a higher severity when integrating it in the current state of Redmine (before 0.9 feature freeze).

NB: With all these patches there exists a chance that the users enter comments with markup which /could/ make the UI break. It should be handled with care. This might also be a good reason to decline all off the three patches...
--------------------------------------------------------------------------------
Text formatting on documents index added in r3602.
--------------------------------------------------------------------------------
I'm attaching a improved (imho) version of Micha's third patch (the one that deals with time entry comments).

It 'textilizes' time entry comments *and* removes the length restriction. Also, the form text_fields to enter the time entries were replaced by text_areas's.
--------------------------------------------------------------------------------
related with #8668 - missing WIki full textile for project overview
--------------------------------------------------------------------------------
Terence Mill wrote:
> related with #8668 - missing WIki full textile for project overview

Not missing on present day.

News are textilized
time entry comment are not textilized
--------------------------------------------------------------------------------
Ivan Cenov wrote:
> Terence Mill wrote:
> > related with #8668 - missing WIki full textile for project overview
>
> Not missing on present day.

I've updated #8668 accordingly. Thanks for mentioning it.

Ivan Cenov wrote:
> News are textilized

News items are indeed textilized, but not the news summary.
--------------------------------------------------------------------------------
+1. This is very useful.

When is this likely to be fully accomplished?
--------------------------------------------------------------------------------
+1
Textilization in the above mentioned areas would be helpful.
--------------------------------------------------------------------------------
The attached patch adds textilization to spent time comments also.
--------------------------------------------------------------------------------
Having textilization support for spent time comments is quite useful. Please let me know if tests are required for my patch.
--------------------------------------------------------------------------------
The document and news already seems to have textilization support as it seems. Don't know since when though!

Can we also complete the last part as well?

*Second oldest unresolved issue by now.*
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------


related_issues

relates,Closed,3740,Code syntax highlighting not working in Document page
relates,Closed,5104,Description of document not wikified on documents index
relates,New,258,Textilize document snippet on overview and activity page
relates,Closed,8668,make project overview text input fully wiki input text enabled
relates,Closed,1179,Optionally allow Text and Long Text custom fields support wiki formatting
duplicates,Closed,3406,Documents view does not parse textile syntax, while detailed view in documents does.
duplicates,Closed,221,Textilized timelog comments
duplicates,Closed,4579,Missing Textilization on Document Index
duplicates,Closed,3815,Format links in Timelog
duplicates,Closed,3810,Link to SCM Revision from Time Tracking Summary
duplicates,Closed,4627,Wiki style Formatting in a few places
duplicates,Closed,6038,wiki formatting in spent time comments

Admin Redmine さんがほぼ2年前に更新

  • カテゴリText formatting_26 にセット
  • 対象バージョンUnplanned backlogs_23 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0