Vote #63094: Embedded repository images in the wiki - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #63094

未完了

« 前 | 次 »

Embedded repository images in the wiki

Admin Redmine さんがほぼ2年前に追加. ほぼ2年前に更新.

ステータス:

New

優先度:

通常

担当者:

カテゴリ:

Wiki_1

対象バージョン:

開始日:

2008/04/25

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/1106

category_id:

version_id:

issue_org_id:

1106

author_id:

886

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[New]

引用

説明

It would be very useful if one can embed an image stored in the repository in the wiki, something like:

(!)source(:)path/to/image.png(!)

Ignore the '(' and ')' chars, they are just to avoid wiki processing.

journals

I could be a good idea, but I have some fears concerning security issue: how to be sure that the linked image is not a "bad-ass in disguise" which could eventually break the redmine presenting it or other? Could be a problem too, to determine if the currently logged user can has access to the repository: it would be a shame that redmine display an image that the user haven't right to see.
--------------------------------------------------------------------------------
I don't see the problem, it should be just expanded to the repository URL.

What I'm doing now is make that expansion myself, I use: (!)[full url](!). If the user don't have repository access, the image simply will be not shown (because the browser will get a 403 or whatever the current mechanism is).

It would be wonderful if Redmine do that expansion for me :) (this way I don't have to worry if Redmine change it's URL scheme in the future or if I deploy my Redmine differently in the future)
--------------------------------------------------------------------------------
This seems to fix it
--------------------------------------------------------------------------------
I meant this:

http://github.com/koke/redmine/commit/ae1220435b2e30beae69caccd996cd1870ac2202
--------------------------------------------------------------------------------
Great. It's planned to be included in upstream? =)
--------------------------------------------------------------------------------
Leandro Lucarella wrote:
> Great. It's planned to be included in upstream? =)

If there was some tests for it I don't see why not. Might need to also check permissions to make sure the user is allowed to browse a repository.
--------------------------------------------------------------------------------
Has this feature ever been integrated? I tried to use the (!)source(:)path/to/image.png(!) syntax but it did not work. It would be very useful!
In the same way, when I try to open .png files in my SVN repository, I cannot see them inside the web browser. I am always asked to download them as files.

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
+1 This would be very nice.

I'm guessing the plans to include it upstream fell through the cracks some time ago though.
--------------------------------------------------------------------------------
+1 I need this feature also a lot.

Has anyone the patch from Jorge Bernal, because the link to github is broken?

Best regards
--------------------------------------------------------------------------------
+1 I need this feature too. Please....
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

related_issues

duplicates,Closed,1752,allow source:/path/to/picture to be used when using inline image tag
duplicates,Closed,8293,Reference images checked into the repository