プロジェクト

全般

プロフィール

Vote #63190

完了

Feature to view whole the file from /repositories/revision page

Admin Redmine さんがほぼ2年前に追加. ほぼ2年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
SCM_3
対象バージョン:
開始日:
2008/05/07
期日:
進捗率:

0%

予定工数:
category_id:
3
version_id:
2
issue_org_id:
1202
author_id:
332
assigned_to_id:
0
comments:
4
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Here is a patch to add feature to view the whole file of the revision from Redmines /repositories/revision page.

Redmine can view differences against previous revision, but sometimes I want to view the whole file to check the context.


journals

Sorry, I forgot to attach the patch.
--------------------------------------------------------------------------------
Updated my patch.
I found that link to /repositories/annotate/ is more usuful for code review.
--------------------------------------------------------------------------------
As of r1552, each change is a link to the whole file.
--------------------------------------------------------------------------------
I applied r1552 to the 0.7.3 sources because we really like this feature.

When I compare that changeset to the patch here I notice two differences:

1.) This patch has a without_leading_slash() call in the link construction logic, but r1552 does not and indeed I had to add it to the patch I apply, r1552 as applied creates broken links for me. Why was that taken out, is it no longer needed against the sources targeting 0.8?

2.) This patch creates "annotate" URLs but r1552 does not, it creates "entry" URLs. I agree with Go MAEDA that annotate is nice and more useful. Is there a reason that was not used as suggested in this patch?

The patch I apply looks like the attached file.

--------------------------------------------------------------------------------

Admin Redmine さんがほぼ2年前に更新

  • カテゴリSCM_3 にセット
  • 対象バージョン0.8_2 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0