Vote #63337
完了In Activity views, changesets titles can be multiline while they should not
0%
説明
This concerns both HTML view and Atom feed.
Are concerned entries for repository changeset whose content is
- multiline
- first line is short
I can't find an example in Redmine.org development Activity timeline, because Jean-Philippe usualy does not commit with such a changelog, so here is a example :
This commit fixes : - #13 - #34
In this case, truncate would return a truncated string, no matter if it contains newlines. This multilines string end up raw, in XML
Attached patch is one working solution and works on my instance. It uses a helper, very similar to truncate, but ensuring truncated string is NOT multiline. Feel free to comment.
journals
An other solution would be to simply replace \n with a space.
What do you think ?
--------------------------------------------------------------------------------
Jean-Philippe, this would fix the problem equally well, it is only a matter of taste. Mine is that a space is a char already used very often, so I find it hard to guess which spaces are genuine and which are not. How about " \ " or " / " or " ^ " or " - " or " > " ?
In any case, that will be a matter of taste and fix the problem, so just pick up the one you prefer. Ask for another patch if you want.
--------------------------------------------------------------------------------
Paul, your patch should define format_truncate_single_line in ApplicationHelper since atom feeds may be rendered from any controller (not just ProjectsController).
Anyway, fix is applied in r1491 usings spaces.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Confirmed,34025,Issue subject truncated to 100 chars in the list from Projects > View all issues > Atom