Vote #63412
完了CVS: add support for modules names with spaces
0%
説明
redmine fails to import changes from CVS module with space in the name:
For example module: "module with spaces" - redmine generate command which makes cvs to treat the module name as several modules separated with spaces.
Solution is to put module name into the quotes:
Here is patch to fix this:
file: lib/redmine/scm/adapters/cvs_adapter.rb
68c68
< cmd << " #{path_with_project}"
---
> cmd << ' "'+"#{path_with_project}"+'"'
113c113
< cmd << " #{path_with_project}"
---
> cmd << ' "'+"#{path_with_project}"+'"'
journals
Here is full fix - for all cvs 8 calls the adapter does:
<pre>
68c68
< cmd << " #{path_with_project}"
---
> cmd << ' "'+"#{path_with_project}"+'"'
113c113
< cmd << " #{path_with_project}"
---
> cmd << ' "'+"#{path_with_project}"+'"'
233c233
< cmd = "#{CVS_BIN} -d #{root_url} rdiff -u -r#{identifier_to} -r#{identifier_from} #{path_with_project}"
---
> cmd = "#{CVS_BIN} -d #{root_url} rdiff -u -r#{identifier_to} -r#{identifier_from} \"#{path_with_project}\""
248c248
< cmd = "#{CVS_BIN} -d #{root_url} co -r#{identifier} -p #{path_with_project}"
---
> cmd = "#{CVS_BIN} -d #{root_url} co -r#{identifier} -p \"#{path_with_project}\""
261c261
< cmd = "#{CVS_BIN} -d #{root_url} rannotate -r#{identifier} #{path_with_project}"
---
> cmd = "#{CVS_BIN} -d #{root_url} rannotate -r#{identifier} \"#{path_with_project}\""
</pre>
--------------------------------------------------------------------------------
Fixed in r1527 using the shell_quote method instead.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
duplicates,Closed,1642,CVS: add support for modules names with spaces (was #1434).