+1 - this would be a very good feature for those of us using Redmine for project planning/management vs simple bug tracking.
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1, agree with Lane
--------------------------------------------------------------------------------
Should be a plugin, not a feature: redmine has to stay as lightweight as possible out of the box.
--------------------------------------------------------------------------------
+1, A fist step: allow comments on Changesets, it would be a big improvement in this direction.
--------------------------------------------------------------------------------
I agree. Allow comments on Changesets is more simple to begin.

*Review Board*: OpenSource (
http://www.review-board.org/

*Atlassian Crucible* Commercial (Has more features then Review Board)
http://www.atlassian.com/software/crucible/screenshots/default.jsp

--------------------------------------------------------------------------------
Agreed, I use redmine at work for several projects and we would benefit from repository comments. I would like to replicate the github comment system, where you can tag your comment with a specific line number. That way my team could use it as a lightweight code review system. Once that works, I would like to add a feature that allows the commiter to request reviews from other users.
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
I wrote the part for adding comments to a changesets (using the existing Journal model). I couldn't figure out how to get a checkbox to show up in the email notification prefs, but I also wrote the code that sends an email to the revision committer (and other users who have commented) when someone comments on a revision.

Please let me know what I can improve/fix, This is my first contribution to Redmine :)

I've attached my diff against r2824
--------------------------------------------------------------------------------
hmm, didn't see that code review plugin... guess this issue got a little stale :) I still like the github interface better, which is what I was going for. Any thoughts? Should this code stay outside of Redmine Core?
--------------------------------------------------------------------------------
There is code review plugin for redmine. It looks great: http://www.redmine.org/boards/3/topics/5878
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
You can use the "Code Review plugin":http://www.redmine.org/plugins/codereview. It works very well and quite the perfect module.
--------------------------------------------------------------------------------
Dipan Mehta wrote:
> You can use the "Code Review plugin":http://www.redmine.org/plugins/codereview. It works very well and quite the perfect module.

no it's not giving accept/reject functionality and not e-mailing status to the person who commited into repository.

you can only comment on specific revision line or whole revision (not really convinient because it creates an issue per each line).

in other words: its not suitable for using in production environment.

i read a lot about gerrit/reviewboard might give it a try later.

--------------------------------------------------------------------------------
+1
nowadays from a developer team perspective this is a must have feature.
--------------------------------------------------------------------------------
@pasquale : there is this plugin which is compatible with version 4.0: https://www.redmine.org/plugins/redmine_code_review
--------------------------------------------------------------------------------
Hi Robert, thanks for your answer. I was looking for something similar to Review Board core or integration.
Do you use "redmine_code_review":https://www.redmine.org/plugins/redmine_code_review in your daily workflow with your peers?

--------------------------------------------------------------------------------
No, I have no experience with it. Never done Code Reviews, unfortunately.
--------------------------------------------------------------------------------
pasquale [:dedalus] wrote:
> +1
> nowadays from a developer team perspective this is a must have feature.

I'd recommend using gitlab with pull requests, much better for code review. Also you can integrate gitlab with redmine by disabling issues in the gitlab and linking them to your redmine installation.
--------------------------------------------------------------------------------
GitLab Is very good, but I'm on Mercurial repositories.
--------------------------------------------------------------------------------
As Idea, recently bugzilla has integrated an external code review tool (Phabricator) with this "approach":https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html and now a specific section is present in the issue page as show under:
!{width: 500px; border: 1px solid grey}.moz-phab.png!

A similar implementation on Redmine side, could be a great improvement\step forward for the community.
--------------------------------------------------------------------------------

relates,New,7747,Add capability to ask\accept\reject review of patches (flag support on attachments)
relates,New,1339,Comments on revisions
duplicates,Closed,469,Code Review/Approve workflow?