Vote #64309: Missing checks for nils in the WikiController - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #64309

完了

Missing checks for nils in the WikiController

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Wiki_1

対象バージョン:

0.8_2

開始日:

2008/12/19

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/2360

category_id:

version_id:

issue_org_id:

2360

author_id:

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

I had a public page on my wiki which I moved to a private project. Web spiders have cached the url and are trying to hit the pages. Instead of getting 404 errors though, they are throwing NoMethodErrors on a nil object. It looks like several actions in the WikiController are not checking for nil object before calling methods on them

undefined method diff' for nil:NilClass [RAILS_ROOT]/app/controllers/wiki_controller.rb:129:indiff'
undefined method annotate' for nil:NilClass [RAILS_ROOT]/app/controllers/wiki_controller.rb:135:inannotate'
undefined method content' for nil:NilClass [RAILS_ROOT]/app/controllers/wiki_controller.rb:115:inhistory'

journals

Fixed in r2145.
Just saw that you assigned it to you, sorry.
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> Just saw that you assigned it to you, sorry.

It's ok. I assign issues to myself that I'm confidant that I can handle, feel free to steal them from me.
--------------------------------------------------------------------------------