プロジェクト

全般

プロフィール

Vote #64408

完了

Login and mail should not be case sensitive

Admin Redmine さんが約3年前に追加. 約3年前に更新.

ステータス:
Closed
優先度:
高め
担当者:
-
カテゴリ:
Accounts / authentication_7
対象バージョン:
開始日:
2009/01/08
期日:
進捗率:

100%

予定工数:
category_id:
7
version_id:
14
issue_org_id:
2473
author_id:
3344
assigned_to_id:
5
comments:
10
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Actually, uniqueness tests on login and mail fields are case sensitive, so you can have many accounts with same login and/or mail. And the "=" statement isn't case sensitive for strings on all databases, the method find_by_login need a fix to be case insensitive like find_by_mail.

For example, when i use Redmine with sqlite3, there are sides effects with "On the fly" ldap acounts creation and with SVN users automatic assignement because of find_by_login matching "login" with "login" but not "login" with "Login" ...


journals

Duplicate #2330

--------------------------------------------------------------------------------
Is this patch going to be included in the core redmine product? We're having problems with our LDAP logins at present - we treat usernames as being case-insensitive, however redmine currently does not.
--------------------------------------------------------------------------------
Tony Arnold wrote:
> Is this patch going to be included in the core redmine product? We're having problems with our LDAP logins at present - we treat usernames as being case-insensitive, however redmine currently does not.

It will be great if it's included in redmine. We have the same problem.
--------------------------------------------------------------------------------
Teddy L wrote:
> Actually, uniqueness tests on login and mail fields are case sensitive, so you can have many accounts with same login and/or mail. And the "=" statement isn't case sensitive for strings on all databases, the method *find_by_login* need a fix to be case insensitive like *find_by_mail*.
>
> For example, when i use Redmine with sqlite3, there are sides effects with "On the fly" ldap acounts creation and with SVN users automatic assignement because of *find_by_login* matching "login" with "login" but not "login" with "Login" ...

Thank you, Teddy! Your patch works with 0.8-stable!
--------------------------------------------------------------------------------
Patch has been updated.
--------------------------------------------------------------------------------
Patch #4732 addresses the same problem, but there at least PostgreSQL and MySQL should use the index instead of a table scan.

Dear maintainers: Please do include one of those fixes!
--------------------------------------------------------------------------------
Just a comment: In the SMTP point of view, the local part of email addresses IS case-sensitive (RFC821, RFC822, RFC2821). username@domain.org is not the same mailbox as Username@domain.org. Don't you think considering email addresses as case insensitive could have some undesired side effects?...
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Created patches on github:
For the validation: http://github.com/GregMefford/redmine/commit/8269a9f774e3e41c0ddd0b4c2913dcc000cdbb82
For the user login: http://github.com/GregMefford/redmine/commit/022c8addba1714bc47e90747e33533702fcb1ca6
--------------------------------------------------------------------------------
I've committed a patch by Greg Mefford that makes the user login's case insensitive (r3807).
--------------------------------------------------------------------------------


related_issues

relates,Closed,4732,Make login case-insensitive also for PostgreSQL
duplicates,Closed,2330,Option for able to turn on case insensitive login

Admin Redmine さんが約3年前に更新

  • カテゴリAccounts / authentication_7 にセット
  • 対象バージョン1.0.0 (RC)_14 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0