プロジェクト

全般

プロフィール

Vote #64745

完了

clickable/linkable line #'s while browsing the repo

Admin Redmine さんがほぼ2年前に追加. ほぼ2年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
UI_10
対象バージョン:
開始日:
2009/02/25
期日:
進捗率:

0%

予定工数:
category_id:
10
version_id:
8
issue_org_id:
2835
author_id:
4162
assigned_to_id:
0
comments:
6
status_id:
5
tracker_id:
2
plus1:
1
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

A user on the #redmine channel requests clickable/linkable line numbers while repo browsing. Here is a simple patch for the views and a little css tweak.

worksforme :)


journals

+1, it seems to me that the chosen implementation has a pretty low severity in contrast to a the highly improved useability it provides...
--------------------------------------------------------------------------------
Committed in r2527 with sligth changes:
* title attribute removed (hardcoded english word)
* change to scm.css removed (not related to this feature)

Thanks.
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> Committed in r2527 with sligth changes:
> * ...
> * change to scm.css removed (not related to this feature)

I am in the opinion that it ís related in the sense of the styling of the feature. As such: I think these selectors maybe shouldn't be declared in source:/trunk/public/stylesheets/scm.css. Instead they seem to belong to the source:/trunk/public/stylesheets/application.css.

See the following screenshots:

|=. *Without the CSS style-declarations (as committed)* |=. *With the CSS style-declarations (like the patch)* |
| !linenumbers_without_css.jpg! | !linenumbers_with_css.jpg! |

As you see the changes are:
* on @hover@ -> underlining removed
* color -> instead of default link-color a more sophisticated gray-teint is used.

Though, consider it just a minor CSS-improvement... ;)

Thanks for your fast response on this issue...
--------------------------------------------------------------------------------
Yes, sorry. The style is committed in r2555.

> Instead they seem to belong to the source:/trunk/public/stylesheets/application.css

scm.css is included when browsing a repo or viewing a file. So I don't think this style is needed in application.css
Am I wrong?
--------------------------------------------------------------------------------
Merged in 0.8-stable in r2556.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

Admin Redmine さんがほぼ2年前に更新

  • カテゴリUI_10 にセット
  • 対象バージョン0.8.2_8 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0