プロジェクト

全般

プロフィール

Vote #64766

完了

Redmine::WikiFormatting.register not raise ArgumentError

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
-
対象バージョン:
開始日:
2009/02/27
期日:
進捗率:

0%

予定工数:
category_id:
0
version_id:
6
issue_org_id:
2856
author_id:
4223
assigned_to_id:
0
comments:
1
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Hi.

Redmine::WikiFormatting.register not raise ArgumentError.

./script/console
001:>> Redmine::WikiFormatting.register("foo", "bar", "baz") #=> {:helper=>"baz", :formatter=>"bar"}
002:>> Redmine::WikiFormatting.register("foo", "bar", "baz") #=> {:helper=>"baz", :formatter=>"bar"}
003:>> Redmine::WikiFormatting.register("foo", "bar", "baz") #=> {:helper=>"baz", :formatter=>"bar"}

I maked patch for fix this bug.

./script/console
001:>Redmine::WikiFormatting.register("foo", "bar", "baz") #=> {:helper=>"baz", :formatter=>"bar"}
002:>> Redmine::WikiFormatting.register("foo", "bar", "baz")
ArgumentError: format name 'foo' is already taken

thanks.

Index: lib/redmine/wiki_formatting.rb
===================================================================
--- lib/redmine/wiki_formatting.rb      (revision 2480)
+++ lib/redmine/wiki_formatting.rb      (working copy)
@@ -25,7 +25,7 @@
       end

       def register(name, formatter, helper)
-        raise ArgumentError, "format name '#{name}' is already taken" if @@formatters[name]
+        raise ArgumentError, "format name '#{name}' is already taken" if @@formatters[name.to_sym]
         @@formatters[name.to_sym] = {:formatter => formatter, :helper => helper}
       end

journals

Applied in r2562. Thanks.
--------------------------------------------------------------------------------

Admin Redmine さんが3年以上前に更新

  • 対象バージョン0.9.0_6 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0