Vote #64961: Show issue history using tabs - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #64961

完了

Show issue history using tabs

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Issues_2

対象バージョン:

4.1.0_127

開始日:

2009/03/26

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/3058

category_id:

version_id:

127

issue_org_id:

3058

author_id:

assigned_to_id:

comments:

107

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

We have some issues where there are so many Status/priority/custom fields changes that you have to scroll heaps to find the useful messages that users have written.

It would be nice to be able to filter out things from the issue history. For example, next to the "History" text you could have the links "Show All" and "Show Messages". Selecting "Show Messages" would only show non-empty messages. It would also be great to remember the last selected option for the remaining session at a minimum (globally, probably not per issue to avoid overheads), or have a default in the user preferences.

journals

I didn't see any other issues like this when I submitted, but I just noticed that this is similar to #3037 - not a duplicate, but similar.
--------------------------------------------------------------------------------
I also just noticed that if #3046 were to be implemented, then it would work as another filter type in my proposal - "Show Associated Revisions"
--------------------------------------------------------------------------------
I'm happy with Nick's proposal for filtering as this covers most of the problem I was talking about in #3037.
--------------------------------------------------------------------------------
One other counter to this would be to set the "Show All" or "Show messages" flag at the role level. You could still have the toggle at the "history" level to override this.
--------------------------------------------------------------------------------
This issue seems to have grown stagnant but seems to be very helpful. At a minimum there should be the ability to filter out the history to show only the notes added to an issue (and vice versa).
--------------------------------------------------------------------------------
+1
There is an "Issue History Tab":https://github.com/tastapod/redmine_issue_history_tabs plugin that works with 1.2.2. But the comment feature is buggy. Of course if anyone wants to take a shot a fixing it...

Here is a link to the issue:
https://github.com/tastapod/redmine_issue_history_tabs/issues/4
--------------------------------------------------------------------------------
+1. The way I would envision this is simply, for both default and custom fields, have an option to select whether or not they show in the Issue History.

For instance, we have a custom field called "Order" which we use for a custom backlog view to let product managers sort what's next in the pipeline. They move things around a lot, so the issue histories are cluttered up with perhaps a couple dozen or more messages of "Order changed to xx". Being able to select to hide changes to that field would be great.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I wrote a patch to implement this issue.
This patch introduces a new checkbox "Show notes only". We can hide/show details by checking it.

*showing all journals, like current Redmine:*
!{border: 1px solid #aaa;}show-all-journals.png!

*showing notes only:*
!{border: 1px solid #aaa;}show-notes-only.png!

--------------------------------------------------------------------------------
Go MAEDA wrote:
> I wrote a patch to implement this issue.
> This patch introduces a new checkbox "Show notes only". We can hide/show details by checking it.

Updated the patch (code cleanup): attachment:show-notes-only-2.diff
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Could this be included in 3.2.0? By this change, users can easily see all conversation on a issue. It increases productivity.

trac already has this feature (see the following screenshot).

!trac-show-property-changes.png!
--------------------------------------------------------------------------------
I don't think a checkbox looks very good there. I'm using the "Redmine Issue Detailed Tabs & Time":http://www.redmine.org/plugins/redmine_issue_detailed_tabs_time plugin which adds tabs for different sections. This looks much better than a toggle check and offers more possible functionality. Tabs are used in Jira and it looks much cleaner.

Redmine plugin:
!{border: 1px solid #aaa;}RedmineTabs.png!

Jira:
!{border: 1px solid #aaa;}JiraTabs.png!
--------------------------------------------------------------------------------
budo kaiman wrote:
> I don't think a checkbox looks very good there. I'm using the "Redmine Issue Detailed Tabs & Time":http://www.redmine.org/plugins/redmine_issue_detailed_tabs_time plugin which adds tabs for different sections. This looks much better than a toggle check and offers more possible functionality. Tabs are used in Jira and it looks much cleaner.

I Agree, Jira`s tabs variant is much better. It can be extended to show "Work Log", "Commits' tabs in the future.
--------------------------------------------------------------------------------
+1 for tabs
--------------------------------------------------------------------------------
I think we need a bit more time for this and 3.2.0 is now scheduled for the next week.
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
Here is a updated patch: attachment:show-notes-only-v3.diff
We can use tabs to switch views.

*"All" tab (notes, details) :*
!history-all.png!

*"Notes" tab (notes only) :*
!history-notes.png!
--------------------------------------------------------------------------------
Sorry, some files were missing in the patch.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Hi,

The solution with 2 tabs is good, but in my opinion it'll be very helpful for the users to have also the following tabs available:
- *Spent time*: with all the spent times added to the respective issue (of course, depending on the user rights)
- *Activity*: all the entries without notes

That means 4 tabs in totals:
- All (activity + notes)
- Activity
- Notes
- Spent Times

Maybe also the associated revisions can be added as tab, but I'm not sure about this one :)

If you're agree with this proposal we can contribute with an updated patch which implement the tabs.
Go MAEDA wrote:
> Here is a updated patch: attachment:show-notes-only-v3.diff
> We can use tabs to switch views.
>

--------------------------------------------------------------------------------
Marius Balteanu wrote:
> Hi,
>
> The solution with 2 tabs is good, but in my opinion it'll be very helpful for the users to have also the following tabs available:
> - *Spent time*: with all the spent times added to the respective issue (of course, depending on the user rights)
> - *Activity*: all the entries without notes
>
> That means 4 tabs in totals:
> - All (activity + notes)
> - Activity
> - Notes
> - Spent Times

Spent time would be a good tab to have, but Activity should definitely be part of this.

Marius Balteanu wrote:
> Maybe also the associated revisions can be added as tab, but I'm not sure about this one :)

Personally, I think that the associated revisions should be a tab and not have the weird little sidebar thing. If the patch to implement tabs is accepted, moving revisions to a tab should be done as a new feature, not part of this.

---

One general comment that I have about the patch (just from a quick glance, if I missed something let me know) is that the default tab probably shouldn't always be "All". This could probably be handled in a few ways, below are some options (the second being my preferred method):

* Add a default tab setting
* Remember the last tab the user used with "All" as default at first

--------------------------------------------------------------------------------
Hi,
During this implementation, Can you please also consider to provide a hook.
We have already defined some tabs in the ticket history region through a plugin development(currently overriding the corresponding partial).
Thanks.
--------------------------------------------------------------------------------
There's still some work to implement what is requested here (additional tabs, hook, memorization of last tab...)
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> There's still some work to implement what is requested here (additional tabs, hook, memorization of last tab...)

I think that we can implement only attachment:show-notes-only-v3.diff in 3.3.0 and other requests in future releases.
--------------------------------------------------------------------------------
This is great work going on.

There is another issue where the same was discussed in great detail - #4487 Do check and try to use some of these ideas.

Add related #4487.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Go MAEDA wrote:
> Jean-Philippe Lang wrote:
> > There's still some work to implement what is requested here (additional tabs, hook, memorization of last tab...)
>
> I think that we can implement only attachment:show-notes-only-v3.diff in 3.3.0 and other requests in future releases.

We got some issues with time spent feature after applying show-notes-only-v3.diff
If you click on the spent time summit in the issues description ( which links to /issues/1111/time_entries ) the issues just reloads instead of showing a list of all time entries for the issue.
Anyone else got this problem?

--------------------------------------------------------------------------------
@Mark, did you manage to resolve the issue with time entries?
--------------------------------------------------------------------------------
Still some work to be done.
--------------------------------------------------------------------------------
I've attached a series of patches that implement this feature. Because the change is quite big, I've split the changes in multiple patches.

h3. 01_allow-tabs-to-have-a-custom-action.patch

This patch allows render_tabs to have custom action for onclick and also, make the partial rendering optional. In this way, tabs can use the same div (partial) for displaying content.

h3. 02_show-issue-history-in-tabs.patch

This patch display issue history in three tabs:
* All: all journals
* Notes: only journals with notes
* History: only journals with history changes and without notes

The notes tab is default when the tab parameters doesn't exists.

h3. 03_move-changesets-to-its-own-tab.patch

This patch moves the associated revisions to a new tab and uses the look and feel from the journals to display the changesets.

h3. 04_add-time-entries-tab-to-issue-history-tabs.patch

This patch adds a new tab with the issue's visible spent times. The same look and feel from journals is used. Related to #5061.

h3. 05_load-changesets-and-time-entries-tabs-async.patch

This patch changes the way in which the changesets and time entries tabs are loaded in order to use ajax calls only on user request. In this way, we speed up a little bit the issue show page. Journals are still loaded in the same time with the issue.

h3. 06_load-remote-tab-only-once.patch

I think it doesn't worth it to make an ajax call each time when the user clicks on changeset or time entries tabs

Let's discuss this implementation for Redmine version:3.5.0 (I think that the change is too big for version:3.4.0). In "Zitec":https://zitec.com, we're using from the beginning some plugins that implement the tabs, but each time we had multiple issues with them. I really think that this feature is needed and also, having the tabs async implemented, we can add more features in the future (some examples: affected branches and files from git revisions, time in state..).

Regarding the memorization of last tab, I'm not sure that is a good idea because if I'm on the changeset tab of the current issue, it doesn't mean that I want to see the same tab first when I open the next issue. If it's really required, I prefer to have it configurable.

Any feedback is appreciated (attached is a printscreen with all 5 tabs).
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> Still some work to be done.

New patches have been submitted by Marius BALTEANU.
Let's consider implementing this feature.
--------------------------------------------------------------------------------
> Any feedback is appreciated (attached is a printscreen with all 5 tabs).

This looks excellent, one small comment I have is that it would be nice to have avatars shown in the "Associated Revisions" tab like they are for other journals.

> Regarding the memorization of last tab, I'm not sure that is a good idea because if I'm on the changeset tab of the current issue, it doesn't mean that I want to see the same tab first when I open the next issue. If it's really required, I prefer to have it configurable.

I can understand why you feel that way, but I still believe it would be useful. Particularly, if I wanted to go through the time log or commit history of a bunch of issues, I would scroll through and open them. If the last tab was remembered then I'd only have to change tab once when I started and then change it back to whatever I want to see when I open the next issue after I'm done. If it were a configurable setting then I'd either have to change the tab for each issue I view, or navigate the settings to change the default before and then after, both of which can be a bit cumbersome. If you still feel opposed to it, that's fine but I'd at least like to express why I feel it would be valuable.
--------------------------------------------------------------------------------
budo kaiman wrote:
> This looks excellent, one small comment I have is that it would be nice to have avatars shown in the "Associated Revisions" tab like they are for other journals.
The avatars are already added, but they are missing from the screenshot because the feature is disabled on my local environment.

> I can understand why you feel that way, but I still believe it would be useful. Particularly, if I wanted to go through the time log or commit history of a bunch of issues, I would scroll through and open them. If the last tab was remembered then I'd only have to change tab once when I started and then change it back to whatever I want to see when I open the next issue after I'm done. If it were a configurable setting then I'd either have to change the tab for each issue I view, or navigate the settings to change the default before and then after, both of which can be a bit cumbersome. If you still feel opposed to it, that's fine but I'd at least like to express why I feel it would be valuable.
It is a valid point of view. What about having the "Last visited tab" as an option in the default tab setting (along with the tabs)? Basically, each Redmine administrator can set as default tab setting for issues one of the following options: All, Notes, History, Spent time, Associated Revisions and Last visited tab.
--------------------------------------------------------------------------------
> It is a valid point of view. What about having the "Last visited tab" as an option in the default tab setting (along with the tabs)? Basically, each Redmine administrator can set as default tab setting for issues one of the following options: All, Notes, History, Spent time, Associated Revisions and Last visited tab.

I think that is a very sensible solution, though I'm not sure if it would be better as a user preference than an administrator setting.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I really do like the tabbed solution for this issue.

My two cents on the patches provided in note-32 based on a visual scan of the patches and the posted screenshot:
* 'All' tab does not include spent time entries and associated revisions (this seems logical seeing where we are coming from, but it might be unexpected behaviour for an 'All' tab)
** and if these were to be merged into the 'All' tab too, then it would provide a false overview of issues' journals as their items aren't journals (only notes and property changes are journals)
* to see all the associated revisions of an issue, one now has to click one more time (on the tab) than before (they were immediately visible along the history), which might be a drawback for some (I can live with it though)
* I think that a 'properties' or 'property changes' label for the 'history' tab is better considering its content and the terminology used throughout Redmine (eg. see the label of the issue edit form [which is 'change properties'])
* additional plugin hooks for the spent time and associated revisions tab views are not included
* regarding the last visited tab memoization: I like the solution proposed by Marius in note-35, but, as Budo, I also like to see such a setting as a user preference instead of a system-wide (admin) setting

All in all I'm pretty positive about the patch series. This feature seems to be coming along nicely... Thanks Marius for your work on this.
--------------------------------------------------------------------------------
Thanks Mischa for your feedback.

Mischa The Evil wrote:
> I really do like the tabbed solution for this issue.
> My two cents on the patches provided in note-32 based on a visual scan of the patches and the posted screenshot:
> * 'All' tab does not include spent time entries and associated revisions (this seems logical seeing where we are coming from, but it might be unexpected behaviour for an 'All' tab)
> ** and if these were to be merged into the 'All' tab too, then it would provide a false overview of issues' journals as their items aren't journals (only notes and property changes are journals)
1. It is better to rename the 'All' tab with the current label 'History'?
2. It'll be nice to have the time entries and associated revisions merged in an 'All' or 'Activity' tab, but maybe it'll be done in a future version.
> * to see all the associated revisions of an issue, one now has to click one more time (on the tab) than before (they were immediately visible along the history), which might be a drawback for some (I can live with it though)
> * I think that a 'properties' or 'property changes' label for the 'history' tab is better considering its content and the terminology used throughout Redmine (eg. see the label of the issue edit form [which is 'change properties'])
3. 'Changed properties' sounds good for you?
> * additional plugin hooks for the spent time and associated revisions tab views are not included
4. I'll a update the patches to include the hooks.
> * regarding the last visited tab memoization: I like the solution proposed by Marius in note-35, but, as Budo, I also like to see such a setting as a user preference instead of a system-wide (admin) setting
5. I'll create a new patch for this feature. I think the best way to implement this is to have the both settings: one in admin to configure the default value for new users, and one as a user preference.

--------------------------------------------------------------------------------
Updated the patch series (01-05) in order to apply cleanly to the current trunk and to include the feedback from Mischa:
* Renamed the tab "All" to "History"
* Renamed the tab "History" to "Property changes"
* Added hooks for changeset and time entries tabs
* Updated tests

_Please remove the first version of patches (except 06_load-remote-tab-only-once.patch)_

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Updated the patch series (01-05) [...]

Nice! Thanks for incorporating my feedback. To summarize the remaining outstanding tasks:
* Add setting(s) for memoization of the last visited tab
** I don't think we need an admin setting as well as a user preference though. I think that only having a user preference will suffice.
* Merge time entries and associated revisions with journals into an 'All' or 'Activity' tab

> _Please remove the first version of patches (except 06_load-remote-tab-only-once.patch)_

Done.
--------------------------------------------------------------------------------
Thanks!

Mischa The Evil wrote:
> * Add setting(s) for memoization of the last visited tab
> ** I don't think we need an admin setting as well as a user preference though. I think that only having a user preference will suffice.
Is on my to do list.

> * Merge time entries and associated revisions with journals into an 'All' or 'Activity' tab
I'll work on this after these patches are committed because the changes are quite big, hard to maintain and also, to be honest, I need a confirmation from Jean-Philippe Lang that we're on the right way with the implementation.

--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> > * Merge time entries and associated revisions with journals into an 'All' or 'Activity' tab
> I'll work on this after these patches are committed because the changes are quite big, hard to maintain and also, to be honest, I need a confirmation from Jean-Philippe Lang that we're on the right way with the implementation.

Please don't get me wrong. I didn't mean to say that this particular change is a requirement before this patch serial can make it into the core. It is something that could well be handled through a separate issue after integration of this issue. I just wanted to give a summary of things mentioned throughout this issue which are not (yet) covered by your patches.
--------------------------------------------------------------------------------
If you change presentation of associated revisions, maybe you could keep #13715 in mind?
--------------------------------------------------------------------------------
Here is a fixed version of the patch. While viewing the repository entries, there was some problem - Tabs didn't opening, because of 'onclick' action.
--------------------------------------------------------------------------------
Andrey Lobanov, thanks for finding and fixing the issue. I reworked your fix a little bit in order to clean up the view file.

I'm attaching the updated patches which cleanly apply on the current trunk (r16963) and incorporate the changes from #26638 and test fixes for rails 5.

Also, I've finished the last patch for this ticket (07_user_preference_for_issue_history_default_tab_r16963.patch) which adds the possibility for the users to select the default issue history tab as preference. The following options are available: notes (default), history, properties, time_entries, changesets and last visited tab.

!user_pref.png!

Jean-Philippe Lang, I think that I've covered all the required changes and the patches are ready for review. I'm assigning you in order to take a call regarding them (it'll be very useful for me if you can do this as soon as you can because there are a lot of changes and it is hard and time consuming for me to maintain these 7 patches).
--------------------------------------------------------------------------------
This looks great, thanks for all your hard work on this. Hopefully it can be incorporated soon.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I'm setting target version to version:"4.0.0" in order to get at least a feedback from Jean-Philippe Lang. It is a long awaited feature, with more than 30 watchers, a lot of related/duplicated issues and patches dragged from version 3.2.0. Also, I'm sure that once we implement this feature, we can make a lot of improvements on top of it.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Updated the patch series to apply cleanly on the current trunk version.
--------------------------------------------------------------------------------
Thank you for the patches series. I hope I will be able to review it soon but I have to unassign this from 4.0 if we want to release before the end of september.
--------------------------------------------------------------------------------
> I have to unassign this from 4.0 if we want to release before the end of september.

It really makes sense to prioritize things to release 4.0 as soon as possible. Let's consider to deliver this in 4.1.0 :)
--------------------------------------------------------------------------------
Go MAEDA wrote:
> > I have to unassign this from 4.0 if we want to release before the end of september.
>
> It really makes sense to prioritize things to release 4.0 as soon as possible. Let's consider to deliver this in 4.1.0 :)

I’m happy with this decision.
--------------------------------------------------------------------------------
As it's the end of November now and the release hasn't happened yet, may we reconsider an integration of this feature in 4.0.0 again?
The issue is quite old and provides a high UX improvement which I think many folks would love to see in the next major release.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Updated the patches series to apply cleanly on the current trunk. Jean-Philippe, please do not forget about this feature.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Hi,
I hope that this functionality will be included on next Redmine 4.1.0 release.
Is there anything that I can help with this ?
--------------------------------------------------------------------------------
Ko Nagase wrote:
> Hi,
> I hope that this functionality will be included on next Redmine 4.1.0 release.
> Is there anything that I can help with this ?

No, you can't, it is Jean-Philippe decision on this feature.

In the meantime, I've updated the patch series to apply cleanly and I've added a new patch (attachment:0008-Remove-history-label-and-no-data.patch) to remove the history label and the "No data" block when there are no history/spent times or revisions.
--------------------------------------------------------------------------------
Thanks Marius for updating the patches. They are now committed, thanks for your hard work on this!
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
A small problem was reported by Mizuki in #31599. I've attached there the fix.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> A small problem was reported by Mizuki in #31599. I've attached there the fix.

Committed the patch in r18311. Thanks.
--------------------------------------------------------------------------------
In IE11 it gives this error on the console: Expected ')'

https://www.redmine.org/projects/redmine/repository/revisions/18276/diff/trunk/public/javascripts/application.js

IE11 does not seem to support Default function parameters.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/default_parameters#Browser_compatibility

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
This patch works with IE11.

<pre><code class="diff">
diff --git a/public/javascripts/application.js b/public/javascripts/application.js
index 7a2805d97..019b45dc4 100644
--- a/public/javascripts/application.js
+++ b/public/javascripts/application.js
@@ -385,7 +385,8 @@ function showIssueHistory(journal, url) {
return false;
}

-function getRemoteTab(name, remote_url, url, load_always = false) {
+function getRemoteTab(name, remote_url, url, load_always) {
+ load_always = load_always || false;
var tab_content = $('#tab-content-' + name);

tab_content.parent().find('.tab-content').hide();
</code></pre>

This also solves.
https://www.redmine.org/issues/31433#note-12
--------------------------------------------------------------------------------
Yuichi HARADA wrote:
> This patch works with IE11.
>
> [...]
>
> This also solves.
> https://www.redmine.org/issues/31433#note-12

Thanks Yuichi for catching this issue. Your fix is good, it can be committed.
--------------------------------------------------------------------------------
Yuichi HARADA wrote:
> This patch works with IE11.
>
> [...]
>
> This also solves.
> https://www.redmine.org/issues/31433#note-12

Committed. Thanks.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
A cross-Browser compatibility issue caused by the changes has been reported as #32529.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> A cross-Browser compatibility issue caused by the changes has been reported as #32529.

I've posted a fix which is good enough for now, but I'm still looking for a better solution for the future. The problem is caused by this line source:trunk/app/views/common/_tabs.html.erb#L27 which calls the onclick functions in a non element context.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Dears,
just an additional feature to mention it will be great if the PDF export of the issue will include the time entry(time+comment+custome fields) under history
Thanks.
--------------------------------------------------------------------------------
Ali Hamdan wrote:
> Dears,
> just an additional feature to mention it will be great if the PDF export of the issue will include the time entry(time+comment+custome fields) under history
> Thanks.

Please open a new issue for this request.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

related_issues

relates,New,3046,Mix associated revisions with journal entries
relates,New,15409,Is it possible to view History section in pages?
relates,New,4487,Add better presentation of issue status history
relates,Closed,5061,Show time log entries in issue history
relates,Closed,16052,Consider a better associated revisions block in the issue tracker
relates,Closed,21585,"Associated revisions" to be minimized / opened by click
relates,Closed,31438,Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological order
relates,Closed,31599,'selected' class disappears from the tab of the input field when switching the issue history tab
relates,Closed,32198,Issues associated revisions not showing due to bad reference to lvar instead of ivar
relates,Closed,32529,The end of the URL is replaced with "undefined" in IE11 and Edge
relates,Closed,33338,Property changes tab does not show journals with both property changes and notes
duplicates,Closed,13298,Grouping issue history (activity) in issue history tabs
duplicates,Closed,8536,Separate notes/comments from issue updates