Vote #65007
完了Issue with two digit year on Logtime
0%
説明
I entered a two digit year in Logtime. The result was that the year showed up as 0009 instead of 2009.
I am using Redmine 0.8.0.devel.2643 (MySQL)
journals
!TwoDigitYear.JPG!
--------------------------------------------------------------------------------
That's how the ruby Date#parse method behaves:
<pre>
irb(main):003:0> Date.parse("09-02-04").year
=> 9
irb(main):004:0> Date.parse("2009-02-04").year
=> 2009
</pre>
I don't know if it's worth hacking it.
--------------------------------------------------------------------------------
If possible, Lock the date fields from entering the values manually & let the user to select from the Calendar control will prevent this issue.
In my observation, most of the users are using the Calendar control.
--------------------------------------------------------------------------------
This is still reproduceable. I checked this and can confirm this on current trunk.
Jean Philippe wrote:
> I don't know if it's worth hacking it.
The validation should be improved or the datefield should only allow 4 digit years. The method doesn't need to be hacked. But it should be validated in the correct way to prepend such an entry.
I set it as a candidate for the next minor release as this could cause misleading timelogs.
--------------------------------------------------------------------------------
Fixed in r11472. Same validations than issue start/due dates are applied and "09-02-04" is no longer considered as valid.
--------------------------------------------------------------------------------
Merged.
--------------------------------------------------------------------------------