Vote #65011
完了Bug in spent time report - the start date isn't included
100%
説明
I've just been checking spent time reports for this week. I've logged time on both 2009-04-01 and 2009-04-02 but if I ask for a report from these days, the report displays the column for 2009-04-01 but doesn't display any values in it. If I change the start date to 2009-03-31 then suddenly the values appear. See the attached images which show this. In image 1, no values are listed under 2009-04-01 but in the second image the correct values are listed.
Redmine-0.8.2
sqlite-3.5.9
ruby-1.8.6 on win32
rails-2.1.2
journals
I'm experiencing the same problem on Redmine 0.8.2.stable (SQLite).
Using the "last 7 days" drop down option has the same behaviour.
I assume this has something to do with converting the date "2009-05-04" into the correct datetime "2009-05-04 00:00:00".
In fact, this bug is better shown by selecting "today" or setting the 'from' and 'to' fields to the same day. No data is shown. However, move the 'from' date back a day and you get todays data but not yesterdays.
I narrowed it down to here:
source:tags/0.8.2/app/controllers/timelog_controller.rb
Lines 91 and 158 show:
['spent_on BETWEEN ? AND ?', @from, @to]
Clearly this isn't going to show all data from today, if @from and @to are the same value.
Perhaps we could add a line near L285 saying:
@from = @from - 1
My knowledge of Ruby programming is quite limited, so I welcome any suggestions.
--------------------------------------------------------------------------------
Is there any chance this could be fixed at some point? We have to tie up time reports from Redmine with our companie's time-tracking system. Having to remember to subtract '1' from the from date isn't always done which makes the tying up inaccurate.
Thanks
Russell
--------------------------------------------------------------------------------
Russell Hind wrote:
> Is there any chance this could be fixed at some point?
Does anyone have a suggestion or patch to help us out with this issue?
Thanks advance!
--------------------------------------------------------------------------------
Fixed in r3009. This bug was specific to SQLite.
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> Fixed in r3009. This bug was specific to SQLite.
Thanks for solving and notifying us!
--------------------------------------------------------------------------------
Yes thanks for fixing this, it will help greatly.
--------------------------------------------------------------------------------
Merged into 0.8-stable in r3046.
--------------------------------------------------------------------------------