Vote #65147
完了remove "main-menu" div when the menu is empty
100%
説明
On some pages, like Home or My page, the project menu is empty but the div html is still present.
It's a problem when you a background image in CSS, because you see the background image without the menu items (see the screenshot).
Could you remove:
or add a CSS class to identify an empty menu ?
Thank you very much.
journals
Fixed by:
* Saving for the result of render_main_menu into menu_html
* Adding a class "empty" on main_menu if menu_html.nil?
The attached patch should resolve this issue.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
JPLang, pushing this up on your radar. The patch seems ok, though I'm not sure this kind of logic should be in a view, I don't have a better idea at the moment though.
--------------------------------------------------------------------------------
Felix Schäfer wrote:
> The patch seems ok, though I'm not sure this kind of logic should be in a view, I don't have a better idea at the moment though.
I agree. I've committed a different version of it which will not display the main-menu div if it's empty ("commit":http://github.com/edavis10/redmine/commit/7514e12d331bea026155df6cdc2b68df8b77d7b1 r3539)
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,New,13773,remove "main-menu" div when the project menu is empty