Vote #65184
完了Add favicon to base layout
100%
journals
favicon.ico found in public is added so that browsers do not get 404 errors.
But it's just a blank icon so I see no reason to add this tag, until we have a official Redmine logo.
--------------------------------------------------------------------------------
Also, this tag won't work if the application is installed in a sub-URI.
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> Also, this tag won't work if the application is installed in a sub-URI.
I think we could still link to a favicon in a sub-URI. Some browsers won't pick it up but most will. If I can't get it to work, then I'll re-close this ticket.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
+1 vote - A favicon would help me to quickly identify Redmine in my (extensive) bookmarks :-)
Agree that Redmine need a favicon/logo first though. I could ask our design to come up one if you like.
--------------------------------------------------------------------------------
James Robertson wrote:
> Agree that Redmine need a favicon/logo first though. I could ask our design to come up one if you like.
James Robertson, there is a thread about the Redmine logo as well as a beta version that I packaged up for the community. I'd appreciate your help to clean it up and do any revisions you see fit.
http://www.redmine.org/boards/1/topics/1183
--------------------------------------------------------------------------------
Hi Eric. I've mentioned this to our designer, Kelly, but it looks like your fairly far through the process already. Good work.
--------------------------------------------------------------------------------
All I did was create the git repo and package it up. Martin Herr is the designer.
--------------------------------------------------------------------------------
Still, I can't see why redMine should not have the tag in @<head>@.
It would be much easier to replace the "dummy" favicon with a new one instead of searching where in the source code the tag is missing and update it.
I would add the tag to exist, even if the favicon file is a 1px file.
Thank you.
--------------------------------------------------------------------------------
+1 from me.
Also it will be neat to allow specify icon in custom theme via some ruby code or template.
--------------------------------------------------------------------------------
I've take an quick patch for this feature:
in app/views/layouts/base.rhtml, insert after <head>:
<link rel="shortcut icon" href="/favicon.ico" />
and restart redmine
--------------------------------------------------------------------------------
+1
I made a tiny plugin to add favicon.ico
With the plugin, the icon of the official logo is displayed on the address bar.
http://github.com/YukiKita/redmine_favicon
--------------------------------------------------------------------------------
Redmine includes a default favicon since r3845.
So you can either include the fixed link in the base layout, or (better) allow themes to overwrite it. This can be achieved by using my [[PluginList#Favicon-Plugin|Favicon plugin]].
--------------------------------------------------------------------------------
I've updated Redmine's favicon to support suburis now (r3894).
Holger and Yuki Kita: the icon link is generated by ApplicationHelper#favicon so your plugins can now override that method if you want to change the path.
--------------------------------------------------------------------------------
Merged to 1.0-stable
--------------------------------------------------------------------------------
Line 866 in application_helper.rb now reads (v1.0.4):
<pre>def favicon
"<link rel='shortcut icon' href='#{image_path('/favicon.ico')}' />"
end</pre>
instead of (r3894)
<pre>def favicon
"<link rel='shortcut icon' href='#{Redmine::Utils.relative_url_root}/favicon.ico' />"
end</pre>
Shows favicon.ico if listed under public/images directory, but currently not showing in default theme? I don't know how this would affect themes.
--------------------------------------------------------------------------------