autologin does not work when i am logging in by my openid url
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I can't reproduce this on the latest trunk version. Am I testing it correctly?

# Login as admin
# Setup OpenID url
# Logout
# Login as the OpenID url with "Remember Me"
# Enter OpenID authentication at OpenID host
# Logged into Redmine
# Close browser, clearing session cookies
# Start browser
# Visit Redmine
# Am still logged in from the "Remember Me"

--------------------------------------------------------------------------------
<pre>
--- app/controllers/account_controller.rb
+++ app/controllers/account_controller.rb
@@ -150,7 +150,7 @@ class AccountController < ApplicationController

def open_id_authenticate(openid_url)
- authenticate_with_open_id(openid_url, :required => [:nickname, :fullname, :email], :return_to => signin_url) do |result, identity_url, registration|
+ authenticate_with_open_id(openid_url, :required => [:nickname, :fullname, :email], :return_to => signin_url(:autologin => params[:autologin])) do |result, identity_url, registration|
if result.successful?
user = User.find_or_initialize_by_identity_url(identity_url)
if user.new_record?
</pre>
--------------------------------------------------------------------------------
My session resets each browser restart.
Here: rm.smix.name is clean redmine installation with a couple of projects.
(sorry I don't want search bots to index it)
--------------------------------------------------------------------------------
I actually have the some problem (using myopenid.com). This has never worked for me.
--------------------------------------------------------------------------------
This is present in 1.0.2. edavis10 had this to say in #redmine,

bq. OpenID doesn't work with autologin because of how it comes back to Redmine. Autologin works with normal sessions.

"cant reproduce" resolution should be removed.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
This issue still exists for me using 1.1.0.stable.4761
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Elias Chistyakov wrote:
> [...]

I can confirm this bug still exists in 2.1.4.stable and the quoted patch works. I've attached one that applies to 2.1.4.stable, since that is likely easier for you.

I tested this with Firefox 17.0.1 and IE9.

To reproduce, I followed Eric Davis route similarly:

# Login using OpenID url and register user
# Logout
# Login with the OpenID url, selecting "Auto Login"
# Enter OpenID authentication at OpenID host
# Logged into Redmine
# Close browser, clearing session cookies
# Start browser
# Visit Redmine Homepage (not /login)
# Am no longer logged in (of course, with the patch, I am.)

Also, if it's relevant, I have auto logins setup to stay current for 7 days. (Although, I don't think that should matter.)
--------------------------------------------------------------------------------
Fixed in r11521.
--------------------------------------------------------------------------------
Merged.
--------------------------------------------------------------------------------