プロジェクト

全般

プロフィール

Vote #65539

完了

Status change info duplicates on the issue screen

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Issues_2
対象バージョン:
開始日:
2009/07/29
期日:
進捗率:

0%

予定工数:
category_id:
2
version_id:
14
issue_org_id:
3690
author_id:
6870
assigned_to_id:
1
comments:
22
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

After upgrade to r2819 i got this strange behavior - all the status/priority changes are displayed twice on the issue screen. For example if i changed status from New to Resolved there would be two identical lines under Updated by: Status changed from New to Resolved. In the email notifications all is normal and reported only once.


journals

I'm not able to reproduce. Please read [[SubmittingBugs]] and make sure to test without any Redmine plugins installed.
--------------------------------------------------------------------------------
I get this same issue.
I have done some more investigation... it's only when RAILS_ENV is set to production.
I'm running with passenger with RAILS_ENV set to development the duplication of journal entries no longer happens. weird.

--------------------------------------------------------------------------------
It seems that the journal gets recorded twice only with the plugin "Issues Group":http://www.redmine.org/boards/3/topics/4701 installed. Without it everything looks normal, so i guess that there is some incompatibility with this plugin.

--------------------------------------------------------------------------------
After further investigation i found out that *after_save* procedure for class Issue (*create_journal*) called twice if Issues Group plugin installed. I tried following workaround:

* commented out *after_save*

* did the callback in C++ style

<pre><code class="ruby">
def save(*args)
super
create_journal
end
</pre>

this way everything works as it should be.

To me it seems like some bug in Rails interpreter itself but i am new to Ruby and Rails so it is just guess

--------------------------------------------------------------------------------
Small changes to the code to favor args and return value

<pre><code class="ruby">
def save(*args)
value = super(*args)
create_journal
return value
end
</pre>
--------------------------------------------------------------------------------
is this going to redmine trunk?
--------------------------------------------------------------------------------
great work btw :)
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> I'm not able to reproduce. Please read [[SubmittingBugs]] and make sure to test without any Redmine plugins installed.

respect, because they believe the community have to patch redmine sources instead of patching plugins. the solution posted below destroys ability to post issue changes via email.
--------------------------------------------------------------------------------
Same issue

!Journal_Detail_Duplicate.jpg!

Redmine 0.9.2.devel.3474 (MySQL)

--------------------------------------------------------------------------------
This is fixed in r3499.
Saving an issue twice won't duplicate change details any more.
--------------------------------------------------------------------------------
Still the same issue. :(

!RedMine_History_Duplicate.jpg!

Redmine 0.9.3.devel.3514 (MySQL)
--------------------------------------------------------------------------------
!RedMine_History_Duplicate.jpg!
--------------------------------------------------------------------------------
The fix is not retroactive, it won't remove existing duplicates from your database.
Did the last issue update that I see on your screenshot occur after you upgraded to r3499?
--------------------------------------------------------------------------------
Yes, I am getting the duplicate issue after upgrading to latest revision (Redmine 0.9.3.devel.3514 (MySQL) )

I understand it won't remove existing duplicates from the database
--------------------------------------------------------------------------------
Do you have Issues Group plugin installed? In my case this was related to Issue Groups plugin - it seems that Rails somehow mixes up callbacks chain for after_save for patched issue model.

--------------------------------------------------------------------------------
<pre>
C:\Program Files\redmine\current>ruby script\about
About your application's environment
Ruby version 1.8.6 (i386-mswin32)
RubyGems version 1.3.5
Rack version 1.0
Rails version 2.3.5
Active Record version 2.3.5
Active Resource version 2.3.5
Action Mailer version 2.3.5
Active Support version 2.3.5
Application root C:/Program Files/redmine/current
Environment development
Database adapter mysql
Database schema version 20100221100219

About your Redmine plugins
Redmine Reports plugin 0.1.0
Charts Plugin 0.0.14
Redmine Blogs plugin 0.0.4
Timesheet Plugin 0.5.0
Redmine Question plugin 0.3.0
Stuff To Do Plugin 0.3.0
Bulk Time Entry 0.4.0
ezFAQ plugin 0.3.3
Redmine Exception Handler plugin 0.2.0
Redmine Graphs plugin 0.1.0
Redmine Task Board plugin 1.0.0
Redmine System Notification plugin 0.2.0
Tab Plugin 0.3.1

C:\Program Files\redmine\current>
</pre>
--------------------------------------------------------------------------------
Well, try to removing plugins one by one starting with those who patch redmine core (just move their folders to the other location) and see if at some moment in time dups will disappear. Or just remove all of the plugins and check it on the clean redmine.

--------------------------------------------------------------------------------
* I Removed all plugins & still having the same issue. :(

<pre>
C:\Program Files\redmine\current>ruby script/about
About your application's environment
Ruby version 1.8.6 (i386-mswin32)
RubyGems version 1.3.5
Rack version 1.0
Rails version 2.3.5
Active Record version 2.3.5
Active Resource version 2.3.5
Action Mailer version 2.3.5
Active Support version 2.3.5
Application root C:/Program Files/redmine/current
Environment development
Database adapter mysql
Database schema version 20100221100219
</pre>

<pre>
Plugins

No data to display
</pre>
--------------------------------------------------------------------------------
Redmine 0.9.3.devel.3521 (MySQL)
--------------------------------------------------------------------------------
Nanda, I'm really not able to reproduce this behaviour so please try with a fresh checkout.
I'll have to close this ticket if it can't be reproduced.
--------------------------------------------------------------------------------
Jean:

I tried with a fresh checkout(New database), duplication issue is gone. I think there was something wrong with the database.

You can close this issue.

Thank you,
Nanda

--------------------------------------------------------------------------------
Thanks for the feedback. But I don't think there's something wrong with your database. You just need a fresh source.
--------------------------------------------------------------------------------

Admin Redmine さんが約4年前に更新

  • カテゴリIssues_2 にセット
  • 対象バージョン1.0.0 (RC)_14 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0