Vote #65563
完了Login page should not show projects link and search box if authentication is required
0%
説明
If authentication is required then you can't reach any other page unless you have logged in. To avoid confusion for users and for a cleaner login page, the "Projects" link and "Search" box in the header menu should not appear. Any contribution to the header menu from plugins should also be suppressed.
journals
simple approach attached in diff
--------------------------------------------------------------------------------
Nice simple implementation. It would be good to add a short integration test for this to make sure they stay hidden in the future.
--------------------------------------------------------------------------------
Added a test. The menu_manager test suite seemed like a roughly appropriate spot for it.
Adjusted change to remove the entire #quick-search. I don't see any point in leaving the div with no form.
The other approach to this issue is to ask each plugin to respect the login_required setting and adjust Redmine in the menu manager somewhere. This approach would preserve the ability to show menu items to unauthenticated users when login is required, which the approach in this patch does not allow.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Patch committed in r5007. Test slightly edited and moved to @layout_test@.
--------------------------------------------------------------------------------
#2321 - this can be closed too
--------------------------------------------------------------------------------
Done, thanks.
--------------------------------------------------------------------------------
related_issues
duplicates,Closed,2321,Hide search textbox if authorization required