Vote #65629
完了broken downloads of attached files after trac import due to missing mime type definitions
0%
説明
After importing my Trac data to redmine via "migrate_from_trac" I noticed that several files, which have been attached to tickets, cannot be downloaded correctly due to wrong mime type information.
The problem is that several files have no information in column "file_type" of redmine's "attachment" table. This information is being generated by "Redmine::MimeType.of(filename)" which is described in file /lib/redmine/mime_type.rb .
My suggestion is, to add some more mime types to this definition:
MIME_TYPES = {
'text/plain' => 'txt,tpl,properties,patch,diff,ini,readme,install,upgrade',
'text/css' => 'css',
'text/html' => 'html,htm,xhtml',
'text/jsp' => 'jsp',
...
The ones, I added, were:
'application/msword' => 'doc',
'application/vnd.ms-excel' => 'xls',
'application/vnd.ms-powerpoint' => 'ppt',
'application/vnd.ms-powerpoint' => 'pps',
'application/vnd.oasis.opendocument.text' => 'odt',
'application/vnd.oasis.opendocument.presentation' => 'odp',
'application/vnd.oasis.opendocument.spreadsheet' => 'ods',
'application/pdf' => 'pdf',
'application/rtf' => 'rtf',
'application/zip' => 'zip',
'application/x-rar-compressed' => 'rar',
'application/x-tar' => 'tar',
A nice collection of mime types can be found here: http://de.selfhtml.org/diverses/mimetypen.htm#uebersicht
journals
+1
--------------------------------------------------------------------------------
Here a patch with new mime types :
doc, xls, ppt, pps, docx, xlsx, ppsx, pptx, 7zip, odt, ods, odp, csv ...
--------------------------------------------------------------------------------
+1, this is a small issue but a boring one.
--------------------------------------------------------------------------------
See r3258.
--------------------------------------------------------------------------------
Actually, I was wrong, it seems for me (or rather, for one of users) Attachment.content_type is not null, but it contains 'text/html' instead of 'application/pdf'.
Off to debug this some more...
The commit does look good though :)
--------------------------------------------------------------------------------
r3258 causes Internal Error when downloading mime-typeless files. I've just reverted back and it works fine. (filename was a43)
--------------------------------------------------------------------------------
I should note that my database was working on 0.8.7 version of Redmine. I've switched to trunk a week ago. All content_types are blank.
In log files, I was getting this error
<pre>
ArgumentError (:type option required):
app/controllers/attachments_controller.rb:43:in `download'
</pre>
--------------------------------------------------------------------------------
Berk Demirkır wrote:
> r3258 causes Internal Error when downloading mime-typeless files. I've just reverted back and it works fine. (filename was a43)
Fixed in r3281.
--------------------------------------------------------------------------------
Merged in 0.9-stable in r3286.
--------------------------------------------------------------------------------