Vote #65646
完了Editing time entries should show the person involved
0%
説明
I'm currently running the trunk version of 30/8 and I'm working on an evaluation of a project based on the time-tracking features of Redmine. Now I'm cleaning up the activity settings of all the time entries and i noticed that the user involved is not show on the edit form. this is a pain because I've opened all wrongly assigned time entries in a tab, and now I'm not sure who did what and what the correct activity should be. The user is an essential part of the context needed when editing a time entry.
journals
Implemented in Redmine 4.1.0 (#3848).
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
It's implemented only for users with permission to log time for other users. I think we can add an read only field also for users without permissions.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I think we can add an read only field also for users without permissions.
+1
--------------------------------------------------------------------------------
We can show the user as link/string instead of a read only field, it's ok?
!{border: 1px solid grey; width: 50%;}time_entry_user.png!
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Here is the patch, I think it's safe to deliver this in version:"4.1.1"
Tests result "here":https://gitlab.com/redmine-org/redmine/pipelines/126319437
--------------------------------------------------------------------------------
Patch looks good to me!
By the way: When I looked at the current behaviour I was thinking:
Wouldn't it be convenient if the User of each time entry was also displayed in the link text of each time entry on the top? It would address the same problem as in the original post...
I added a potential patch for that...
--------------------------------------------------------------------------------
Both patches committed, thanks.
Just a slight change to Kevin's patch to prevent calling #name on nil.
--------------------------------------------------------------------------------
Test fails:
<pre>
Failure:
TimelogControllerTest#test_get_bulk_edit [/builds/redmine-org/redmine/test/functional/timelog_controller_test.rb:712]:
<03/23/2007 - eCookbook: 4.25 hours> expected but was
<03/23/2007 - eCookbook: 4.25 hours (John Smith)>..
Expected 0 to be >= 1.
bin/rails test test/functional/timelog_controller_test.rb:706
</pre>
--------------------------------------------------------------------------------
Merged.
--------------------------------------------------------------------------------
related_issues
relates,Closed,3848,Permission to log time for another user