Vote #65874
未完了Cross-project redmine links with alternate link text for source and export links.
50%
説明
In Feature #3346 (Support for cross-project revision links), James Wells and Babar O'Cap collaborated to make it possible to create commit and revision links across projects.
I have now extended the @project:@ syntax to @source:@ and @export:@ links and also extended them with the ability to specify alternate link text: "Download filename" instead of projectname:export:foo/bar/path/filename.
I have also corrected the issue causing source and export links to not be properly converted to absolute links in issue update emails. (See Defect #3483)
So... Source and export links now work in emails, can be cross project, and can have alternate display text for the link.
Syntax:
- ["Link alternate display title"=][project:]source:some/path[/file][@52][#L120]
- ["Link alternate display title"=][project:]export:some/path/file[@52]
Note: For the link text, the double-quotes are currently required, even if the text is only one word. I chose to implement the alternate link name functionality in a way that altered the primary regex as little as possible. It's getting a bit unwieldy.
attachment:091018-cross-project_redmine_links-tests.patch contains changes to test/* files as provided in:
- #3346 cross-project_revision_and_commit_links_v5.diff - Patch v5 - from Babar O'Cap, 2009-08-26 03:27
I have no idea how to use, extend, or test this test/* functionality, so I didn't attempt to..
attachment:091018-cross-project_redmine_links.patch contains no test/* file modifications.
journals
oops.. image links don't work for attachments.. that last part was supposed to be:
attachment:091018-cross-project_redmine_links-tests.patch contains changes to test/* files as provided in:
* #3346 cross-project_revision_and_commit_links_v5.diff - Patch v5 - from Babar O'Cap, 2009-08-26 03:27
I have no idea how to use, extend, or test this test/* functionality, so I didn't attempt to..
attachment:091018-cross-project_redmine_links.patch contains no test/* file modifications.
--------------------------------------------------------------------------------
I have discovered an issue with this, which hopefully can be easily resolved...
This patch currently breaks the @!version#6@ syntax. Instead of being a link to the version in the roadmap, it becomes a link to an issue by that number (#6).
--------------------------------------------------------------------------------
Updated patch file, corrects issues with attachment, document, and version links.
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
Any news?
--------------------------------------------------------------------------------
Here's an svn formatted patch against r3618.
It's functional, but could use some refactoring.
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1
This is so damn useful! Why has nobody added it to the roadmap yet!?
--------------------------------------------------------------------------------
Hi William,
Any chance that you can update the patch for redmine 0.9.6 or later?
Thanks in advance!
--------------------------------------------------------------------------------
O'h... I forgot to mention that I tried merging the patch with 0.9.6, but got more merge conflicts than I can safely solve with my limited Ruby knowledge.
--------------------------------------------------------------------------------
My apologies.. I actually started to do this weeks ago and got pulled off on something else..
Attached is 100805-1.0.0_r3854-cross-project_redmine_links.patch, which is a patch against 1.0.0 (source:/trunk@3854).
I did actually generate patches against 0.9.5 (source:/trunk@3815) and 0.9.6 (source:/trunk@3815) as well, but I'm not uploading them because they are identical except for the revision references in the patch. This patch should apply without issue against any trunk or release between r3602 and r3894.
The functional changes in this patch are all in @app/helpers/application_helper.rb@, which has had a couple of recent revisions that would affect line numbers, but the patch should still apply properly to a current trunk. Let me know if you need a patch against a more recent trunk..
--------------------------------------------------------------------------------
Thanks. Can't we get a Target Version for this? How can we convince the core team to integrate this?
I am also adding attachment:100806-0.9.6_add_cross_project_links_with_changesets.patch to use the cross-project wiki formats (_project:r1234_ and _project:commit:ab34cd_) when fixing issues via repository commit keywords.
--------------------------------------------------------------------------------
By the way... attachment:100805-1.0.0_r3854-cross-project_redmine_links.patch doesn't play well with 0.9.6. The trouble starts with:
<pre>
text = text.gsub(%r{([\s\(,\-\>]|^)(!)?(attachment|document|version|commit|source|export|message)?((#|r)(\d+)|(:)([^"\s<>][^\s<>]*?|"[^"]+?"))(?=(?=[[:punct:]]\W)|,|\s|<|$)}) do |m|
</pre>
in 0.9.6 versus the expected
<pre>
text.gsub!(%r{([\s\(,\-\[\>]|^)(!)?(attachment|document|version|commit|source|export|message|project)?((#|r)(\d+)|(:)([^"\s<>][^\s<>]*?|"[^"]+?"))(?=(?=[[:punct:]]\W)|,|\s|\]|<|$)}) do |m|
</pre>
which is what the patch expects.
--------------------------------------------------------------------------------
Subprojects in Redmine are effectively useless without this feature.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Still no plans to include this in near future? Wikis look awful without th ability to display a homan readable text for repository links.
--------------------------------------------------------------------------------
The syntax: [[project:page|text]] should indeed work. It is even weird that it is not the case by default. Probably a problem with the regexp?
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
Yep, it's definitely necessary feature.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Please, also for [[RedmineTextFormattingMarkdown|Markdown]] formatting, #15520.
--------------------------------------------------------------------------------
related_issues
relates,Closed,779,Multiple SCM per project
relates,Closed,7409,Cross project Redmine links
relates,Closed,3346,Support for cross-project revision links
relates,Closed,3483,Relative url for source links in notifications
relates,New,10248,Specific text instead of addresses to the Redmine internal links
relates,New,21443,Links to resources in Markdown
duplicates,Closed,4667,Ability to link to a revision in a subprojects repository