Vote #66761
完了Gravatar breaks layout of "logged in" page
0%
説明
When you enable gravatar on the website it breaks the "logged in as USERNAME" page since there is no clearing after the @h2@ tag inside the @div id="content"@.
In the CSS you could add the following code:
#content h2:after{
content: ".";
visibility: hidden;
display: block;
height: 0;
clear: both;
}but it will only be supported in the later browsers (and will make the change on all pages, not just the logged in as one). Other places in the code you've added empty divs with the @clear:both@ applied to its style attribute so might be needed here aswell.
Now why you ask yourself? The following divs with the @splitcontentleft@ and @splitcontentright@ classes uses up 49% each of the space and since @img.gravatar@ floats to the left it makes the @splitcontentright@ appear below the @splitcontentleft@.
I really hope you all understand me cuz I'm down with a flu and my brain ain't working at top speed. I'll see if I find the rhtml file and I might even add a patch for it. :)
journals
I'm not sure to know what the "logged in as USERNAME" page is.
Could you attach a screenshot?
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
OK, I see (/users/1)
--------------------------------------------------------------------------------
I found the appropriate rhtml file (@app/views/users/show.rhtml@) however there is no @div style="clear: both;"@ after @.splitcontentright@ and I do see one in Firebug so therefor I thought it might be added in some javascript file but found nothing regarding it.
So, I've added a line with the @div@ to @user_show.rhtml@ (diff attached) but not totally sure that it's the way to add it. You be the judge.
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> OK, I see (/users/1)
Sorry, my bad for not pointing that out. I blame the snot! :)
--------------------------------------------------------------------------------
The problem with clear:both; is that it will break if you add another higher floating div (eg. in the sidebar).
I fixed it using another approach in r3562.
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> The problem with clear:both; is that it will break if you add another higher floating div (eg. in the sidebar).
> I fixed it using another approach in r3562.
This though makes other places gravatars are shown (like for instance issues) not align properly. Examples are "Assigned to" and the history of the issue as seen on the screenshot attached.
!gravatar_on_issue.png!
--------------------------------------------------------------------------------
I don't really see what is wrong on your screenshot.
I'm closing this ticket since the initial problem is solved and merged from 0.9.4 release. Open a new ticket if needed.
--------------------------------------------------------------------------------
related_issues
duplicates,Closed,4597,Display weirdness in users/show.rhtml in gravatars are enabled