Vote #67039: openid not validated correctly - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #67039

完了

openid not validated correctly

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

低め

担当者:

カテゴリ:

Accounts / authentication_7

対象バージョン:

1.0.1_21

開始日:

2010/04/12

期日:

進捗率:

100%

予定工数:

0.50時間

Redmineorg_URL:

https://www.redmine.org/issues/5297

category_id:

version_id:

issue_org_id:

5297

author_id:

10251

assigned_to_id:

1188

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

the user supplied a openid with a semicolon instead of the colon. instead of a validation / login error he got a 500. trace is:

NoMethodError (undefined method `downcase' for nil:NilClass):
  app/controllers/account_controller.rb:153:in `open_id_authenticate'
  app/controllers/account_controller.rb:33:in `login'
  passenger (2.2.4) lib/phusion_passenger/rack/request_handler.rb:91:in `process_request'
  passenger (2.2.4) lib/phusion_passenger/abstract_request_handler.rb:206:in `main_loop'
  passenger (2.2.4) lib/phusion_passenger/railz/application_spawner.rb:376:in `start_request_handler'
  passenger (2.2.4) lib/phusion_passenger/railz/application_spawner.rb:181:in `spawn_application!'
  passenger (2.2.4) lib/phusion_passenger/utils.rb:182:in `safe_fork'
  passenger (2.2.4) lib/phusion_passenger/railz/application_spawner.rb:153:in `spawn_application!'
  passenger (2.2.4) lib/phusion_passenger/spawn_manager.rb:271:in `spawn_rails_application'
  passenger (2.2.4) lib/phusion_passenger/abstract_server_collection.rb:80:in `synchronize'
  passenger (2.2.4) lib/phusion_passenger/abstract_server_collection.rb:79:in `synchronize'
  passenger (2.2.4) lib/phusion_passenger/spawn_manager.rb:254:in `spawn_rails_application'
  passenger (2.2.4) lib/phusion_passenger/spawn_manager.rb:153:in `spawn_application'
  passenger (2.2.4) lib/phusion_passenger/spawn_manager.rb:286:in `handle_spawn_application'
  passenger (2.2.4) lib/phusion_passenger/abstract_server.rb:351:in `__send__'
  passenger (2.2.4) lib/phusion_passenger/abstract_server.rb:351:in `main_loop'
  passenger (2.2.4) lib/phusion_passenger/abstract_server.rb:195:in `start_synchronously'

journals

Reproduced on current trunk. Actually, it's a URI or ruby-openid defect. Maybe we could find a workaround to avoid 500 error in Redmine.
--------------------------------------------------------------------------------
Sorry, misread the trace on my laptop, the problem is inside our wrapper in vendor/plugins/open_id_authentication. Patch applied in r3933, but there may be other related bugs, don't hesitate to reopen if so.
--------------------------------------------------------------------------------
Merged to 1.0-stable for release in 1.0.1.
--------------------------------------------------------------------------------