Vote #67324: "with subproject" malfunction - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #67324

完了

"with subproject" malfunction

Admin Redmine さんがほぼ2年前に追加. ほぼ2年前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

対象バージョン:

1.0.0 (RC)_14

開始日:

2010/05/25

期日:

進捗率:

100%

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/5589

category_id:

version_id:

issue_org_id:

5589

author_id:

5171

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

Hello,

When subprojects exist, Roadmap and Activity contain a checkbox "Subprojects" indicating whether to include subprojects in the report or not (see "here":http://demo.redmine.org/projects/diesundjenes/roadmap for example).

If this checkbox is unchecked (default is checked), and then checked again, it doesn't show issues related to subprojects.

Digging a bit in the html code, it appears that two inputs with the same name (with_subprojects) exist. The first one is hidden with a constant value of 0, and the second one is the checkbox. This leads to a querystring that contains "with_subprojects=0&with_subprojects=1", which in turn does NOT include subprojects.

journals

I was able to reproduce, though the error is somewhere else, the second hidden checkbox for with_suprojects is only there to make sure the parameter has a 0 value instead of none if the checkbox is unchecked.

Anyway, the problem is that when you submit your request using the form in the sidebar, you only have the option to show activities that are enabled in the parent project, but you can't select those that are enable in child projects but not in the parent project. Example: parent project without repository, child project with a repository, when you go on activity, the checkins are there, but as soon as you click "apply", they won't appear anymore because you can't select "checkins" from the list.
--------------------------------------------------------------------------------
The hidden input should be there only if there is NO checkbox at all (i.e. no active subprojects).
If there is a checkbox, and it is unchecked, it assigns the value 0 to with_subprojects, and the hidden input is unneeded.
--------------------------------------------------------------------------------
Orgad Shaneh wrote:
> The hidden input should be there only if there is NO checkbox at all (i.e. no active subprojects).
> If there is a checkbox, and it is unchecked, it assigns the value 0 to with_subprojects, and the hidden input is unneeded.

That's irrelevant to your problem.
--------------------------------------------------------------------------------
I'll try to tackle this for 1.0.0.
--------------------------------------------------------------------------------
Felix, are you going to have a patch ready in the next week for this? If not, we'll have to push it to the next release.
--------------------------------------------------------------------------------
Eric Davis wrote:
> Felix, are you going to have a patch ready in the next week for this?

I just got my Laptop back from Apple yesterday, but I should be able to get it done tomorrow.
--------------------------------------------------------------------------------
Eric: here's the patch, I haven't found any tests for the activity fetcher though, but it worked on my test installation. The added overhead should be minimal (unless there's a very large number of subprojects none of which the user has rights to see a certain module for).
--------------------------------------------------------------------------------
Thank you for the patch, I've included it in r3829.

We should take some time after the release to add some tests for the @lib/redmine@ code, it's lacking a lot of coverage.
--------------------------------------------------------------------------------