Vote #67364
完了Wrap text fields properly in PDF
100%
説明
This patch fixes wrapping problems with text fields (subject and custom text and long text fields) when generating a PDF.
The main fixes were:
Single Issue:
- wrap subject in both the page title and in the table cell
- the description was not being printed
- wrap journal details indicating what changed
Issues List:
- wrap text in all cells of the table, regardless of type
- give custom "text" and "long text" fields the same width weight as the subject
journals
Thanks for addressing this Hugo - it will certainly be a nice improvement. I am trying to run the patch but get the following output...
bash-4.1$ patch -p0 < wrap_text_fields_in_pdf_r3764.patch
patching file patch
Hunk #1 FAILED at 87.
Hunk #2 FAILED at 100.
Hunk #3 FAILED at 122.
Hunk #4 FAILED at 140.
Hunk #5 FAILED at 159.
Hunk #6 FAILED at 174.
Hunk #7 FAILED at 185.
Hunk #8 FAILED at 194.
Hunk #9 FAILED at 247.
Hunk #10 FAILED at 286.
10 out of 10 hunks FAILED -- saving rejects to file patch.rej
Any idea what I might be doing wrong? I am running the latest bitnami redmine stack if that gives you any clues.
--------------------------------------------------------------------------------
Eric, can't you check this patch I've just updated for v1.0.2?
Would it be possible to get it in while it is still up-to-date with the latest version of the "lib/redmine/export/pdf.rb" file?
--------------------------------------------------------------------------------
David Le Dieu wrote:
> Any idea what I might be doing wrong? I am running the latest bitnami redmine stack if that gives you any clues.
Not really sure, but most likely at the time the bitnami version had already moved past the v0.9.4 against which the patch was made.
This new version tested successfully against Redmine v1.0.2 (r4213) so you can try it again on that version, although I believe the bitnami is still at v1.0.1 and considering that the patched file was changed from v1.0.1 to v1.0.2 I'm not sure it'll update successfully.
--------------------------------------------------------------------------------
Hi,
is this patch still working for V1.1.0?
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Nope, it does not apply successfully to the latest v1.1.1, since there was a "small change made":/projects/redmine/repository/diff/trunk/lib/redmine/export?rev=4736&rev_to=4104 in r4736 that touched one of the lines of the patch.
I'm attaching a new patch that works on the latest r4784: "issue5629_wrap_text_fields_in_pdf_r4784.patch"
--------------------------------------------------------------------------------
Now, who can pick this up and commit it to trunk?
(before the main code moves yet again and invalidates this patch… it's been 8 months, already!)
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
https://www.chiliproject.org/issues/357
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed in r5604, thanks.
--------------------------------------------------------------------------------
I found the bug of the Automatic line break in Chinese PDF of r5604.
This is FPDF original bug. (Japanse and Korean don't have this problem)
I wrote patch.
--------------------------------------------------------------------------------
Note 13 patch is committed in r5605, thanks.
--------------------------------------------------------------------------------
Thanks for the prompt reply Toshi.
Congrats for the excellent work; things _feel_ much lively around here lately.
--------------------------------------------------------------------------------
related_issues
relates,Closed,61,Broken character encoding in pdf export
relates,Closed,7386,NoMethodError on pdf export
duplicates,Closed,4686,When exporting to PDF, text should wrap and honor newlines, instead of being constrained to one line