Vote #67504
完了Welcome text misses wiki formatting
0%
説明
The attached patch surrounds the welcome text with a @
journals
Holger Just wrote:
> The attached patch surrounds the welcome text with a @<div class="wiki">@ to render the same as all the other info texts.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
This change fixes some issues with overlapping code boxes too.
A different approach is proposed in #12031. I prefer this simpler change though...
--------------------------------------------------------------------------------
Is this a patch that we can still target to 3.1.0? I don't know "how frozen" 3.1-stable is at the moment.
Nevertheless, I think this could be considered a defect, marking this (small) patch a candidate for a future >= 3.1.1 release anyway.
Mischa The Evil wrote:
> A different approach is proposed in !#12031. [...]
A second look at it shows me that it does more than adding a div alone - with the wrong class also, @box@ does not fix the formatting issues that rise when a "pre" block and/or a "pre code" block is being used in the welcome text (@wiki@ class _does_ fix these) - and these changes were found unrelated/unwanted (#12031#note-2).
As such, I'd propose to close issue #12031 in favor of the patch proposed in this patch (which, I think, will also fix the issue that the OP of !#12031 was intending to patch initially).
--------------------------------------------------------------------------------
Patch committed.
--------------------------------------------------------------------------------
Thanks!
--------------------------------------------------------------------------------
related_issues
relates,Closed,12031,welcome text in a div with class box