プロジェクト

全般

プロフィール

Vote #67678

完了

Forum message permalinks don't take pagination into account

Admin Redmine さんが4年以上前に追加. 4年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Forums_5
対象バージョン:
開始日:
2010/07/23
期日:
進捗率:

0%

予定工数:
category_id:
5
version_id:
21
issue_org_id:
5945
author_id:
3866
assigned_to_id:
0
comments:
2
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

The forum message permalinks (i.e. what the "title" of the message (mostly "Re: Original title") points to) doesn't take into account pagination, i.e. messages not on the first page still point to @/boards/:board_id/topics/:topic_id#message-:message_id@, which will take you to the first page, but not to the right message.

One solution would be to make all those links like this @/boards/:board_id/topics/:topic_id?r=:message_id#message-:message_id@, which would take you to the right page each time, or add a parameter for the right page. The problem with the second solution is that it breaks if the pagination size is change at some point, the first solution might be a little more resource-hungry, and especially will reload the page each time you click on one of the permalinks on the page. That shouldn't happen too often though, so I'd favor the first solution more.

One thing that should also be thought out is if we the retain the AJAX pagination on the topics view, or if it should load a whole new page with the @?r=:id_of_the_first_message_on_the_next_page@ parameter.

An example of this behavior can be observed here: http://orga.fachschaften.org/boards/1/topics/31#message-58 doesn't take you to the correct message, http://orga.fachschaften.org/boards/1/topics/31?r=58#message-58 does.


journals

--------------------------------------------------------------------------------
Fixed in r3877.
--------------------------------------------------------------------------------

Admin Redmine さんが4年以上前に更新

  • カテゴリForums_5 にセット
  • 対象バージョン1.0.1_21 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0