プロジェクト

全般

プロフィール

Vote #67974

完了

can't switch between inline and side-by-side diff

Admin Redmine さんがほぼ2年前に追加. ほぼ2年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
UI_10
対象バージョン:
開始日:
2010/08/28
期日:
進捗率:

100%

予定工数:
category_id:
10
version_id:
24
issue_org_id:
6242
author_id:
19622
assigned_to_id:
1188
comments:
14
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
21
ステータス-->[Closed]

説明

I upgraded from 0,.8.4 to 1.0.1 recently. When switching between inline and s-b-s mode, I get an error, such as:

The requested URL /projects/jeenode/repository/diff/Ports/examples/powerdown_demo/powerdown_demo.pde was not found on this server.

The problem is caused by /'s being URL-escaped to %2F - when I manually change them back, the URL works as intended. Here's the URL to which Redmine wants to redirect when switching diff mode in the popup:

http://[...]/projects/jeenode/repository/diff/Ports%2Fexamples%2Fpowerdown_demo%2Fpowerdown_demo.pde?rev=5969&type=inline

(I've edited out the actual server name because it's in a temp location and on a very slow link + machine)


journals

Yes, I also get this error on Centos 5.5.

--------------------------------------------------------------------------------
same as #6292
--------------------------------------------------------------------------------
is it maybe something to do with the escaping for #5548 ?
--------------------------------------------------------------------------------
Same as #6292, we cannot help you until you read [[SubmittingBugs]] and provide requested information. Moreover, I'd like to have minimal steps to reproduce, which SCM do you use, in which version, which OS, etc.
--------------------------------------------------------------------------------
<pre>
About your application's environment
Ruby version 1.8.6 (i486-linux)
RubyGems version 1.3.5
Rack version 1.0
Rails version 2.3.5
Active Record version 2.3.5
Active Resource version 2.3.5
Action Mailer version 2.3.5
Active Support version 2.3.5
Edge Rails revision unknown
Application root /var/www/railsapp
Environment development
Database adapter mysql
Database schema version 0

About your Redmine plugins
Markdown formatter 0.0.1
</pre>

I'm using subversion. To reproduce, here's what I did: took the Redmine turnkey install from http://www.turnkeylinux.org/redmine - then upgraded it as described.
--------------------------------------------------------------------------------
I'm having the same problem with latest "Bitnami Redmine stack":http://bitnami.org/stack/redmine on a Windows 2003 Server standard edition. I have also recently migrated from 0.9.4 to 1.0.1 using the Bitnami upgrade documentation, and I use a Subversion repository. Here are the versions in Bitnami stack :
<pre>
- Redmine 1.0.1
- Apache 2.2.14
- ImageMagick 6.5.6-8-Q8
- MySQL 5.0.83
- Subversion 1.6.6
- Ruby 1.8.7-p249-i386-mingw32
- Rails 2.3.5
- RubyGems 1.3.6
</pre>
The error occurs only when switching between inline and sbs on a single file diff (with the "view differences" combo on top); it's perfectly working when you display the diff of a whole revision. As described on top, the part of the url describing the path in the SCM repository contains %2F instead of /

--------------------------------------------------------------------------------
Same problem for me.

Showing the diff for a file shows automatically sbs-view. Everything works fine.
<pre>
https://servername/projects/myproject/repository/revisions/1084/diff/trunk/lib/model/messages/Incoming.php
</pre>

Switching to inline view (using the dropdown) gives a 404.
<pre>
https://servername/projects/myproject/repository/diff/trunk%2Flib%2Fmodel%2Fmessages%2FIncoming.php?rev=1084&type=inline
</pre>

My configuration:
<pre>
Ruby version 1.8.7 (x86_64-linux)
RubyGems version 1.3.6
Rack version 1.0
Rails version 2.3.5
Active Record version 2.3.5
Active Resource version 2.3.5
Action Mailer version 2.3.5
Active Support version 2.3.5
Edge Rails revision unknown
Application root /srv/rails/redmine-1.0.1
Environment production
Database adapter mysql
Database schema version 20100819172912
</pre>
--------------------------------------------------------------------------------
The same problem for me...

Inline view, shown by default, works fine. Switching to sbs view gives 404 error.

<pre>
Ruby version 1.8.7 (i686-linux)
RubyGems version 1.3.7
Rack version 1.0
Rails version 2.3.5
Active Record version 2.3.5
Active Resource version 2.3.5
Action Mailer version 2.3.5
Active Support version 2.3.5
Edge Rails revision unknown
Application root /opt/rails/redmine-1.0.1
Environment production
Database adapter mysql
Database schema version 20100819172912

svn, version 1.6.12 (r955767)

</pre>
--------------------------------------------------------------------------------
It seems I'm able to reproduce this behaviour. I'll look into it tomorrow extensively.

Note: besides that nobody else here actually posted a stacktrace, it seems that nothing about the error is written to the Rails log :S
--------------------------------------------------------------------------------
Mischa The Evil wrote:
> Note: besides that nobody else here actually posted a stacktrace, it seems that nothing about the error is written to the Rails log :S

It's not a Ruby exception. It's an incorrect URL.
--------------------------------------------------------------------------------
It is an incorrect URL indeed, fixed in http://github.com/thegcat/redmine/commit/0392b9f2b4847218982d948f5eb1beee21f1b1ba

@JB: if you'd be so kind :-)
--------------------------------------------------------------------------------
Thanks! Committed in r4100
--------------------------------------------------------------------------------
Fix confirmed. Thank you Felix! :)
--------------------------------------------------------------------------------
Merged into 1.0-stable for release in 1.0.2
--------------------------------------------------------------------------------

Admin Redmine さんがほぼ2年前に更新

  • カテゴリUI_10 にセット
  • 対象バージョン1.0.2_24 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0