Vote #68055
未完了requires_redmine_plugin should defer loading plugins if not all dependencies are met
0%
説明
requires_redmine_plugin is a nice facility to track inter-plugin dependencies, however, it is useless if I do not want (or cannot) rename plugins I depend on.
I propose that plugins are deferred and loaded at a later time, if possible.
See attached patch for a proposed solution.
journals
Remove debugger code
--------------------------------------------------------------------------------
Also, for some reason, the patch I posted doesn't apply with git am. So if you use that, here's one that does. (No code changes)
--------------------------------------------------------------------------------
Just found a bug with my patch where the asset directory wasn't set properly. Changed it to not replace the rails plugin locator, but use Redmine's in addition to the default one. This probably nicer, anyway, in case people want to add locators themselves. In the new implementation, the Redmine plugin locator doesn't load anything, but is only for querying the Rails plugin search path.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I am stepping down from working on Redmine. If someone else is interesting in working on this issue, feel free to reassign it to them.
Eric Davis
--------------------------------------------------------------------------------
FYI:
https://www.chiliproject.org/issues/256
--------------------------------------------------------------------------------
For anyone not willing to patch the core, not requiring an end user to manage his environment.rb, I found the following workaround to be prepended on the dependent plugin's init.rb:
> dep = File.join(Rails.root,'plugins','<plugin name>')
> ActiveSupport::Dependencies.autoload_paths += [File.join(dep, 'lib')]
> require_dependency File.join(dep, 'init')
--------------------------------------------------------------------------------
Sorry to be late at the party, but I'd like this issue solved as it bothers me from time to time.
I find Tim's proposed implementation a bit complex (and the one integrated in chiliproject is even more complex) where all we'd have to do is defer the requirement check until the end of @Redmine::Plugin.load@ method. Sure it's not as evolved but I think it should be enough.
Here's a proposed patch, I'd like to hear some opinions before committing it, and if you see obvious advantages to Tim's/Chiliproject's approach, let me know.
--------------------------------------------------------------------------------
It seems to be the simplest fix, straight-forward and easy to understand.
The other implementations, much more complex, are error-prone processes in my opinion.
--------------------------------------------------------------------------------
As this issue seems to make no real progress in any direction, I implemented Jean-Baptiste's Patch as a plugin.
Just save them as @plugins/000_pluginloader/init.rb@ and @plugins/zzz_pluginloader/init.rb@. done.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Just a quick update: I merged the two plugin-files into one standalone plugin by abusing the @mirror_assets@ method call in the redmine initializer. This plugin *does not* change the load order of plugins - it only defers the dependency check, as suggested in #6324-8
https://github.com/michaelkrupp/redmine_pluginloader
--------------------------------------------------------------------------------
Following approach is simple and does work. Applied in my_plugin's init.rb to check a dependency dependency_plugin.
The check happens after all plugins have been registered.
<pre>
Rails.configuration.to_prepare do
Redmine::Plugin.find(:my_plugin).requires_redmine_plugin :dependency_plugin, :version_or_higher => '1.0.0'
end
</pre>
--------------------------------------------------------------------------------
related_issues
relates,Closed,5638,Use Bundler (Gemfile) for gem management
duplicates,Reopened,23131,Plugin load order defined by inter-plugin dependencies
Admin Redmine さんが3年以上前に更新
- カテゴリ を Plugin API_20 にセット
- 対象バージョン を Candidate for next major release_32 にセット