Vote #68106
完了Last updated by colum in issue list
0%
説明
Hi,
I think that it will very beneficial if there was an "Last updated by" column in the issue list, so that way users will be able to tell if the issue was updated or not without entering their mailbox.
journals
Just a small correction - last updated by and not just "updated by".
Thanks.
--------------------------------------------------------------------------------
Alexander F wrote:
> Just a small correction - last updated by and not just "updated by".
I've modified the issue-properties to match the precise request.
--------------------------------------------------------------------------------
Does anybody a patch or any workaround?
--------------------------------------------------------------------------------
(Sorry!) "*Have* anybody..."
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
In case if anyone still interested: "last_updated_by_column":https://github.com/neowit/redmine_last_updated_by_column plugin adds "Last Updated by" column to:
* Issues list (as extra column)
* My page (as a separate component)
--------------------------------------------------------------------------------
+1
The plugin above only partially works with Redmine 2.3.1.
1) The last updated by issues block when added "My Page" displays correctly but right clicking on an issue in it doesn't work.
2) On the main "/issues" page a "Last Updated By" column isn't availble as an option in "Available Columns" such that it could be moved into "Selected Columns" so that it would be displayed.
--------------------------------------------------------------------------------
Turns out Redmine 2.3.0 introduced changes that broke "Updated By" on ./issues page.
The "updated version":https://github.com/neowit/redmine_last_updated_by_column of the plugin takes that into account.
--------------------------------------------------------------------------------
+1
Would be nice to have that in Redmine and not just as a plugin
--------------------------------------------------------------------------------
+1
This will be a very usefull feature. I hope it will be added soon!!!
Thanks
--------------------------------------------------------------------------------
We want to see lastly our edited issues (last updated by) and we can inform people if the issue stays on them so much time etc.
Thank you.
--------------------------------------------------------------------------------
+1
definitly more than eye candy
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1
For the people that want this as a plugin, this one works for me:
https://github.com/neowit/redmine_last_updated_by_column.git
--------------------------------------------------------------------------------
I made a patch (with tests) that implements the "Last updated by" as column in issues list. This patch should be applied after the patch from #17720 because it uses the same local as filter "Last updated by".
The patch has one limitation: sorting issues after "Last updated by" column is disabled because I wasn't able to add the sorting query to take into account the "Users display format" setting (in the plugin mentioned above, the user format for this column is hard-coded). Maybe a Redmine contributor can solve this limitation, but in my opinion the patch is useful also with this limitation.
--------------------------------------------------------------------------------
Added a new version (add_column_last_updated_by_v2.patch) that does not contain a unnecessary change presented in the first patch.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I've uploaded a new version of the patch:
- it cleanly apply on the current trunk
- it checks for journal visibility
- fixes the limitation from the previous version of the patch (sorting by "Last updated by" column works now).
Unfortunately, I didn't do any performance test.
I think that it'll be great to deliver this issue along with #17720 and #1474 (there are at least 5 duplicate issues).
--------------------------------------------------------------------------------
Marius, thank you for updating the patch. I hope that this feature will be included in 3.4.0
But a test fails in my environment. Could you check the problem?
<pre>
$ ruby test/unit/query_test.rb
(snip)
1) Failure:
QueryTest#test_query_with_last_updated_by_column [test/unit/query_test.rb:1301]:
--- expected
+++ actual
@@ -1 +1 @@
-["User", "String", "String", "User", "String", "String", "String"]
+["User", "User", "String", "String", "String", "String", "String"]
186 runs, 527 assertions, 1 failures, 0 errors, 0 skips
</pre>
My environment is as follows:
<pre>
Environment:
Redmine version 3.3.2.devel.16248
Ruby version 2.3.1-p112 (2016-04-26) [x86_64-darwin15]
Rails version 4.2.7.1
Environment development
Database adapter SQLite
</pre>
--------------------------------------------------------------------------------
Thanks Go MAEDA for testing the patch. I've attached the fixed version. The problem was generated by the data fixtures (journals weren't loaded by query_test.rb).
Jean-Phillipe Lang, I saw in r16228 that you preferred to generate the test data directly in the tests. It is better than using the existing fixtures?
--------------------------------------------------------------------------------
Thank you for the patch on #6375#note-26 but it still fails.
<pre>
$ ruby test/unit/query_test.rb
(snip)
1) Failure:
QueryTest#test_query_with_last_updated_by_column [test/unit/query_test.rb:1301]:
--- expected
+++ actual
@@ -1 +1 @@
-["User", "String", "String", "User", "String", "String", "String"]
+["User", "User", "String", "String", "String", "String", "String"]
186 runs, 527 assertions, 1 failures, 0 errors, 0 skips
</pre>
--------------------------------------------------------------------------------
Thanks again for testing the patch. Something is wrong with my development instance.
I've attached a new version which passed the tests on both mysql and sqlite3 databases.
<pre>
notroot@b8ae13776d3c:/work$ RAILS_ENV=test rake db:drop db:create && ruby test/unit/query_test.rb
/usr/local/bundle/gems/htmlentities-4.3.1/lib/htmlentities/mappings/expanded.rb:465: warning: duplicated key at line 466 ignored: "inodot"
/usr/local/bundle/gems/htmlentities-4.3.1/lib/htmlentities/mappings/expanded.rb:465: warning: duplicated key at line 466 ignored: "inodot"
/usr/local/bundle/gems/htmlentities-4.3.1/lib/htmlentities/mappings/expanded.rb:465: warning: duplicated key at line 466 ignored: "inodot"
Run options: --seed 496
# Running:
..........................................................................................................................................................................................
Finished in 18.171939s, 10.2356 runs/s, 29.0008 assertions/s.
186 runs, 527 assertions, 0 failures, 0 errors, 0 skips
</pre>
--------------------------------------------------------------------------------
Thanks to Marius, the patch works fine as expected and passed all tests.
Ideally this feature whould be included in 3.4.0 along with #17720.
!6375-screenshot.png!
--------------------------------------------------------------------------------
Feature is added, thanks for the patch Marius. I've reworked the proposed changes a bit:
- Issue#last_updated_by returns nil instead of an empty string when there's no updates
- Issue.load_visible_last_updated_by loads only the last journals instead of loading all of them
- More robust unit test (I had random test failure)
- Functional tests
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
>
> For the people that want this as a plugin, this one works for me:
>
> https://github.com/neowit/redmine_last_updated_by_column.git
In my case it didn't work.
'My Page' gives error
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,17720,Filter issues by "Updated by" and "Last updated by"
duplicates,Closed,9127,Allow "Updated By" as a column in the issues list
duplicates,Closed,9550,Include Updated By and Update Date Time in Issue List(s)
duplicates,Closed,7660,Add the possibility to view the last updater of an issue
duplicates,Closed,22279,Need to get the last user who uptated an issue
duplicates,Closed,11919,Issues list needs some kind of "last-modified-by" mark.
duplicates,Closed,5294,Add a "last comment by" column to the issues list
duplicates,Closed,5791,Set latest journal(log) id when an issue updated (in a issues table)