プロジェクト

全般

プロフィール

Vote #68117

完了

Issue mail should render the HTML version of the issue details

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Issues_2
対象バージョン:
開始日:
2010/09/14
期日:
進捗率:

0%

予定工数:
category_id:
2
version_id:
40
issue_org_id:
6386
author_id:
7914
assigned_to_id:
0
comments:
1
status_id:
5
tracker_id:
2
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

The view issue_edit.text.html.rhtml should use the HTML version of show_detail(). The current implementation looks like:

    <% for detail in @journal.details %>
  • <%= show_detail(detail, true) %>
  • <% end %>

But since this is for an HTML display, the following should be used:

    <% for detail in @journal.details %>
  • <%= show_detail(detail) %>
  • <% end %>

Unfortunately, when that is changed, an error is thrown when updating an issue if an email is sent out. For some reason, the following line from issues_helper.rb (line 147 in 1.0.1):

      old_value = content_tag("strike", old_value) if detail.old_value and (!detail.value or detail.value.empty?)

Causes an exception. The exception is raised because detail.value is a Fixnum and Fixnum doesn't have a .empty? method.


journals

This has been done with r8721 for version:1.4.0; the above mentioned issue had already been fixed by r6323.
--------------------------------------------------------------------------------


related_issues

relates,Closed,10251,Description diff link in note details is relative when received by email

Admin Redmine さんが約4年前に更新

  • カテゴリIssues_2 にセット
  • 対象バージョン1.4.0_40 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0