Vote #68228: Make options parameter optional in User#allowed_to_globally? - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #68228

完了

Make options parameter optional in User#allowed_to_globally?

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Permissions and roles_17

対象バージョン:

2.6.0_81

開始日:

2010/09/26

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/6498

category_id:

version_id:

issue_org_id:

6498

author_id:

347

assigned_to_id:

1188

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

It's optional in @allowed_to?@ so it would make sense to make it optional in @allowed_to_globally?@, too.

Patch is attached.

journals

+1
--------------------------------------------------------------------------------
Yes obviously. This method is not used anywhere in the Redmine code base anymore, but I find lots of usages in plugins on Github (https://github.com/search?o=desc&q=allowed_to_globally&s=indexed&type=Code)

On a side note Jan: I'm trying to spend some time reviewing/merging patches these days, and obviously 4 years old patches with not even a reply are ridiculous. If you want to drop me an email with things you think I can merge directly, let me know (or we can chat about that on freenode eventually, nick=salvor but my IRC client is at $WORK so I'm only behind on weekdays).
--------------------------------------------------------------------------------