Vote #68339: SortHelper missing from CalendarsController - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #68339

完了

SortHelper missing from CalendarsController

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Calendar_36

対象バージョン:

1.0.3_25

開始日:

2010/10/08

期日:

進捗率:

100%

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/6612

category_id:

version_id:

issue_org_id:

6612

author_id:

3866

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

I just tried to show a calendar with a custom query, so something like: @http://my.redmi.ne/issues/calendar?query_id=13@, which causes redmine to quit on a:

NameError (undefined local variable or method `sort_clear' for #):
  app/helpers/queries_helper.rb:75:in `retrieve_query'
  app/controllers/calendars_controller.rb:23:in `show'

The solution is to @include SortHelper@ in @CalendarsController@.

journals

Thanks, I'll fix that.
--------------------------------------------------------------------------------
Fixed in r4245 and added a test case.
--------------------------------------------------------------------------------
Eric Davis wrote:
> * *Target version* set to 1.0.3

Shouldn't this be targetted to version#20?
--------------------------------------------------------------------------------
Mischa The Evil wrote:

> Shouldn't this be targetted to version#20?

No, "CalendarsController":http://www.redmine.org/projects/redmine/repository/entry/branches/1.0-stable/app/controllers/calendars_controller.rb was refactored in the 1.0.x branch too.
--------------------------------------------------------------------------------
Eric Davis wrote:
> Mischa The Evil wrote:
>
> > Shouldn't this be targetted to version#20?
>
> No, "CalendarsController":http://www.redmine.org/projects/redmine/repository/entry/branches/1.0-stable/app/controllers/calendars_controller.rb was refactored in the 1.0.x branch too.

ACK ;)
--------------------------------------------------------------------------------
Merged into 1.0-stable for release in 1.0.3
--------------------------------------------------------------------------------