Vote #68949
完了Non ASCII filename downloaded from repo is broken on Internet Explorer.
0%
説明
On Internet Explorer, a filename downloded from repository is broken, because that filename is consist of multibyte characters. But, that is absolutely normal on Chrome.
In addition, attached files in the Redmine "files" page have no problem.
I think that this code has no problem,
./controllers/attachments_controller.rb:
send_file @attachment.diskfile, :filename => filename_for_content_disposition(@attachment.filename),
... and this code has a problem.
./controllers/repositories_controller.rb:
send_data @content, :filename => @path.split('/').last
I test that modification like below, and it seems successful!
send_data @content, :filename => filename_for_content_disposition(@path.split('/').last)
In my opinion, some of other
send_datas can have similar problems.
journals
What SCM do you use?
--------------------------------------------------------------------------------
Toshi MARUYAMA wrote:
> What SCM do you use?
I use Subversion as SCM.
--------------------------------------------------------------------------------
Subversion stored paths as Unicode.
Can you paste a path and attach a image?
--------------------------------------------------------------------------------
Toshi MARUYAMA wrote:
> Subversion stored paths as Unicode.
> Can you paste a path and attach a image?
http://redmine.~~~.com/projects/~~~/repository/raw/doing/%EC%84%9C~~~%ED%99%98/20090825_%EB%B0%94%EB%A1%9C%EA%B0%80%EA%B8%B0.ppt
--------------------------------------------------------------------------------
Thanks. Is it Korean named file?
--------------------------------------------------------------------------------
Toshi MARUYAMA wrote:
> Thanks. Is it Korean named file?
Yes, it is. And both WRONG(original) and RIGHT(modified) have the exactly same url.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I commited trunk r4816 and 1.1 r4819.
These are images on my Japanese Windows Vista and IE 8.
"send_data" at source:trunk/app/controllers/repositories_controller.rb@4817#L164 is revision and it is ASCII.
--------------------------------------------------------------------------------