Vote #68992
完了Sorting issues in gantt by date, not by id
90%
説明
I can't tell if the prior issues (see below) related to gantt chart issue sorting are about new- or old-style gantt charts. I do know that the default 1.1.0 isn't very useful, since they're sorted by root_id (ie. parent issue id). That has little relation to the order that the issues need to be worked on in. I made a one-line change that worked for me:
# TODO: top level issues should be sorted by start date
def gantt_issue_compare(x, y, issues)
[(x.root.start_date or x.start_date or Date.new()), (x.start_date or Date.new()), x.root_id, x.lft] <=> [(y.root.start_date or y.start_date or Date.new()), (y.start_date or Date.new()), y.root_id, y.lft]
#if x.root_id == y.root_id
# x.lft <=> y.lft
#else
# #x.root_id <=> y.root_id
#end
end
I'm not 100% certain if it works in all cases, but for my DB (multi-project, multi-version, single nesting level issues), it works fine.
journals
Hum, apparently I can't add related issues. They should be:
#5438
#6968
--------------------------------------------------------------------------------
Hi Eli,
And thanks for your patch. Worked fine for me. I'll post here in case this breaks some use cases.
Hope this change will be made available in the next release.
Regards,
Guillaume
--------------------------------------------------------------------------------
Update: the first line didn't work in all cases for me. This one seems to be behaving better:
[(x.root.start_date or x.start_date or Date.new()), x.root_id, (x.start_date or Date.new()), x.lft] <=> [(y.root.start_date or y.start_date or Date.new()), y.root_id, (y.start_date or Date.new()), y.lft]
--------------------------------------------------------------------------------
Hi,
where do I enter this line of code or apply this patch?
Thanks,
Sebastian
--------------------------------------------------------------------------------
@lib/redmine/helpers/gantt_helper.rb (gantt_issue_compare())@ ?
--------------------------------------------------------------------------------
thanks. Works fine.
--------------------------------------------------------------------------------
Anyone knows if we can also sort by name? Or if the above patch could be easily modified to sort by top level issue name (instead of id like current or start date like this fix)?
feel free to move this to a new issue if you feel it's necessary.
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
thanks. Works fine.
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1, related with #8480
--------------------------------------------------------------------------------
I solved this by changing the way to insert issues in the Data Base. I just insert them already in the correct order.
But also I had to change the values of rgt and lft directly on the Data Base, because there were projects already inserted in the system, and doing this I guarantee that all projects will be sorted correctly.
Is attached the diff file and the new script i had to create.
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
This is a patch for trunk r10713.
This patch sort start date algorism is referred from "Redmine Better Gantt Chart Plugin":https://github.com/kulesa/redmine_better_gantt_chart
https://github.com/kulesa/redmine_better_gantt_chart/blob/50c323fe8b6ac667c88b/lib/redmine/helpers/better_gantt.rb#L692
But, issues tree structure is broken by start date sorting.
h3. Redmine trunk r10713
!redmine-trunk-r10713.png!
h3. Patch applied
!redmine-trunk-r10713-patch.png!
--------------------------------------------------------------------------------
FTR the patch in #7456 originally implemented some sorting too.
--------------------------------------------------------------------------------
Hi guys.
I just required the sort by start date and then applied manually the first chunk mentioned on attachment:sort_issues_from_start_date.diff, to my 2.2.0 version, and it worked as expected.
So, could it be possible to apply it on 2.2's trunk or next versions? I see that a default sorting by start_date first has more sense than by issue_id.
Thanks in advance.
--------------------------------------------------------------------------------
New patch is posted at #8366#note-2.
--------------------------------------------------------------------------------
I confirmed #8366 "Change-Gantt-default-sorting-to-start_date-instead-of-id.patch":http://www.redmine.org/attachments/8731/Change-Gantt-default-sorting-to-start_date-instead-of-id.patch fixes note-16 problem.
I re-post it as attachment:gantt-sort-trunk-r11692.diff .
!gantt-sort-trunk-r11692.png!
--------------------------------------------------------------------------------
Thank you for your patch, Toshi.
I applied your patch, and it looked working correctly, first.
However, note-16 problem is still happen to issues which added
after your patch applied.
--------------------------------------------------------------------------------
Yuhki Ishiguro wrote:
> Thank you for your patch, Toshi.
>
> I applied your patch, and it looked working correctly, first.
> However, note-16 problem is still happen to issues which added
> after your patch applied.
Thank you for your trying.
Could you try this patch using another logic.
This logic is from here (in Japanese).
http://d.hatena.ne.jp/itto100pen/20121202
--------------------------------------------------------------------------------
Umm... I tried new patch. And, same things happen.
I show you my Test project.
426 wasn't added correctly, but after adding 428, it was solved.
!gantt.jpg!
--------------------------------------------------------------------------------
I got a suggestion from patch author.
https://twitter.com/nobu_toyofuku/status/326227862808064000
Could you try this patch?
--------------------------------------------------------------------------------
I tried gantt-sort-trunk-r11740.diff, and it seems working correctly!
Thank you !!
Regards,
Yuhki ISHIGURO
--------------------------------------------------------------------------------
attachment:gantt-sort-trunk-r11740.diff does not sort root issues.
This patch fixes it.
--------------------------------------------------------------------------------
Toshi MARUYAMA wrote:
> attachment:gantt-sort-trunk-r11740.diff does not sort root issues.
> This patch fixes it.
I greatly appreciate for you contribution.
I tried your new patch gantt-sort-trunk-r11744.
It works fine, and I think it solves this issue.
Regards,
Yuhki ISHIGURO
--------------------------------------------------------------------------------
Hi,
I tried to apply patch but errors occured :
<pre>
root@linus:/var/www/redmine# patch -p0 < gantt-sort-trunk-r11744.diff
patching file b/lib/redmine/helpers/gantt.rb
Hunk #1 FAILED at 675.
1 out of 1 hunk FAILED -- saving rejects to file b/lib/redmine/helpers/gantt.rb.rej
patching file b/lib/redmine/helpers/gantt.rb
Hunk #1 FAILED at 687.
1 out of 1 hunk FAILED -- saving rejects to file b/lib/redmine/helpers/gantt.rb.rej
patching file b/lib/redmine/helpers/gantt.rb
Hunk #1 FAILED at 686.
1 out of 1 hunk FAILED -- saving rejects to file b/lib/redmine/helpers/gantt.rb.rej
patching file b/lib/redmine/helpers/gantt.rb
Hunk #1 FAILED at 220.
Hunk #2 FAILED at 694.
2 out of 2 hunks FAILED -- saving rejects to file b/lib/redmine/helpers/gantt.rb.rej
</pre>
Some help please ?
Thanks.
Version Info :
Environment:
Redmine version 2.3.0.devel.11744
Ruby version 1.8.7 (x86_64-linux)
Rails version 3.2.13
Environment production
Database adapter MySQL
Redmine plugins:
due_date_reminder 0.3.1
--------------------------------------------------------------------------------
David Dupont wrote:
> Some help please ?
Use -p1 instead of -p0.
<pre>
patch -p1 < gantt-sort-trunk-r11744.diff
</pre>
And this patch is for trunk r11744, not 2.3.0.
--------------------------------------------------------------------------------
Thanks for the answer !
So i can't install it ?
Even if i change the file manually ? Is there too many difference between the trunk and 2.3.0 ?
--------------------------------------------------------------------------------
David Dupont wrote:
> Is there too many difference between the trunk and 2.3.0 ?
There is no difference between trunk r11768 and 2.3-stable r11769 for this patch.
You can apply this patch to 2.3-stable.
--------------------------------------------------------------------------------
This is patch for trunk.
There is no logic change from note-26 patch.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Please correct sort_version_logic(). Only "version.effective_date" contains the start date of a version. Otherwise the versions won't sorted by start date as expected.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Filou Centrinov wrote:
> Please correct sort_version_logic(). Only "version.effective_date" contains the start date of a version. Otherwise the versions won't sorted by start date as expected.
Toshi, can you look into this? Seems there might be something wrong with the tests because this does not trigger test failures.
--------------------------------------------------------------------------------
2.4 feature freeze
--------------------------------------------------------------------------------
I think note 36 patch need to check in version:2.4.0.
--------------------------------------------------------------------------------
Filou Centrinov wrote:
> Please correct sort_version_logic(). Only "version.effective_date" contains the start date of a version. Otherwise the versions won't sorted by start date as expected.
A better option would be to sort versions by @version.effective_date || version.start_date@. A version may not have an effective_date but some issues with start dates assigned to it.
Versions with no start_date nor effective should be listed at the very end. I'm not this is the case with @|| Date.new@.
--------------------------------------------------------------------------------
If it can help, here's an excerpt from #7456 where the idea was also to display shared version before concerned projects:
The shared version is tied to the selected project (also valid for "all projects" Gantt):
parent project -> shared version -> subproject -> shared version issues (including parent project issues)
The shared version is tied to a not-visible-parent project of the selected project:
subproject -> shared version -> shared version issues (excluding parent project issues)
Issue sorting code within a version+project scope:
<pre><code class="ruby">
# Compare issues for rendering order
def gantt_issue_compare(x, y)
if x.parent_id == y.parent_id
# Same level in issue hierarchy
basic_gantt_issue_compare(x, y)
elsif x.root_id == y.root_id || x.root_id == y.id || y.root_id == x.id
# Same issue hierarchy
x.lft <=> y.lft
else
# Distinct hierarchies
x.root_id <=> y.root_id
# TODO : advanced sort between issues when ancestors have been filtered out by query
end
end
def basic_gantt_issue_compare(x, y)
if x.start_date == y.start_date
x.id <=> y.id
elsif x.start_date.nil?
1 # null date appears at the end
elsif y.start_date.nil?
-1
else
x.start_date <=> y.start_date
end
end
</code></pre>
--------------------------------------------------------------------------------
Toshi MARUYAMA wrote:
> I think note 36 patch need to check in version:2.4.0.
Versions are now sorted by effective_date (r12247).
--------------------------------------------------------------------------------
related_issues
relates,Closed,5438,Patch repairing rendering of subtasks in gantt diagram
relates,New,7456,Gantt filters
relates,Closed,6276,Gantt Chart rewrite
relates,New,12730,Fix sorting and PDF output of Gantt diagram & start date calculation and grouping
relates,Closed,7128,New gantt chart does not render subtasks under parent task
relates,New,8897,Be able to reorder tasks/issues in the Gantt chart
relates,Closed,7579,Gantt tab gives internal error.
relates,New,14397,Gantt sorting as a configurable setting
duplicates,Closed,7968,Order tasks by time on Gannt
duplicates,Closed,8480,gantt sorting in redmine 1.2
duplicates,Closed,13238,Sorting in Gantt
duplicates,Closed,6968,Sorting of issues in Gantt
duplicates,Closed,8366,Gantt Version Ordering