Vote #69210
完了"Send account information to the user" only works when password is set
0%
説明
MySQL: 5.1.49
Ruby: 1.8.7
Rails: 2.3.5
Redmine: 1.1.1.stable.4802 (MySQL)
Account information is not sent to users when the box next to "Send account information to the user" is checked on
journals
Can not reproduce with either 1.1-stable or trunk.
Make sure your email delivery is properly setup.
--------------------------------------------------------------------------------
I can reproduce this issue. The problem I see is specific to editing a user.
If you edit a user and have the "Send account information to the user" option checked, the details are only sent to the user if a new password has been explicitly set. ie: If you change their name or email, nothing will be sent.
Is this by design? If so, it's confusing and perhaps the label for the checkbox could be "Send new password to the user" which infers that it will not do anything unless a new password has been entered.
--------------------------------------------------------------------------------
Condition at source:trunk/app/controllers/users_controller.rb#L160 is :
<pre><code class="ruby">
@user.active? && params[:send_information] && !params[:user][:password].blank? && @user.auth_source_id.nil?</code></pre>
So you're right, a new password needs to be entered which is a bit confusing.
This checkbox is used to send new account information to the user at creation too.
--------------------------------------------------------------------------------
I ran into a variant of this bug that I thought was worth mentioning. I'm using LDAP authentication with my Redmine instance and therefore there is no password to change. But when I create a user account in Redmine, I really would like to send an e-mail with the details. So I guess I'm also voting for the idea that any account creation or account change (or even clicking the save button again without changes) be allowed to create the e-mail.
--------------------------------------------------------------------------------
+1. Sending info to LDAP users would be helful.
--------------------------------------------------------------------------------
+1 for LDAP users
Actually, this should be a button visible for admins only.
--------------------------------------------------------------------------------
Etienne Massip wrote:
> Condition at source:trunk/app/controllers/users_controller.rb#L160 is :
> [...]
>
> So you're right, a new password needs to be entered which is a bit confusing.
> This checkbox is used to send new account information to the user at creation too.
Any news on this Etienne? :-)
Maybe this could be fixed in the next minor release?
--------------------------------------------------------------------------------
The existing email notification is used to send the password, that's why it's only sent when the password is set. If we want to be able to send an email in any case, it would be better to define different templates for when:
# the account was created
# the account was updated without password change
# the password was changed
In 2., what should the email look like?
--------------------------------------------------------------------------------
Suggestion:
#
#* object: ??Your account has been created??
#* body: every field name and value visible in the ??Information?? fieldset of the user account screen and password if internal auth
#
#* object: ??Summary of your account??
#* body: every field name and value visible in the ??Information?? fieldset of the user account screen
#
#* object: ??Your authentication information has been updated??
#* body: password and every field name and value visible in the ??Information?? fieldset of the user account screen
_Edited x times_
--------------------------------------------------------------------------------
This is more likely a feature request then a defect.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Change done in r16453. An email with username and login URL will now be sent when the password is not changed.
--------------------------------------------------------------------------------
related_issues
relates,Closed,25249,Change translation for label_send_information