プロジェクト

全般

プロフィール

Vote #69281

未完了

'Invalid form authenticity token' when updating issue causes dataloss

Admin Redmine さんが約2年前に追加. 約2年前に更新.

ステータス:
New
優先度:
通常
担当者:
-
カテゴリ:
Issues_2
対象バージョン:
-
開始日:
2011/02/18
期日:
進捗率:

0%

予定工数:
category_id:
2
version_id:
0
issue_org_id:
7651
author_id:
28751
assigned_to_id:
0
comments:
1
status_id:
1
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[New]

説明

When updating an issue to add a comment, if your session is no longer valid, you receive the error:

'Invalid form authenticity token.'

While this part is correct behaviour, it causes dataloss because:

a) The page with the error does not contain the text of the comment you submitted.
b) At least in Firefox 3.6, the Back button returns to the issue you were updating, but without the text.

I don't operate the redmine server in question, but I verified that this still occurs on demo.redmine.org, so it is a current issue.

To reproduce:

  1. Use the Firefox browser with web developer extension (or any other browser with similar features)

  2. Go to an issue

  3. Click Update

  4. Type some text into a comment

  5. In the web developer toolbar, choose Cookies / Clear Session Cookies

  6. Submit the comment

  7. Error page appears

Actual behaviour:

Error page does not contain text you entered in #3. If you click the Back button, you are returned to the form but without your text.

Expected behaviour:

Error page should additionally contain the text of the comment you entered. Or, alternatively, the Back button should take you to the update page that includes your text.

Notes:

1) Clearing session cookies is fairly common behaviour when testing web applications. While it's obvious that doing this will break a Redmine session (i.e. you shouldn't do it), Redmine doesn't have to add injury to insult by causing annoying dataloss as a result.

2) Other form data is probably lost too but who cares - it's the potentially page-long comment that can be really annoying.

3) I haven't verified what happens with other update form errors such as simultaneous edit. If the same thing happens there, then those could benefit from being fixed, too.


journals

Any progress on this? It's really annoying to lose comments or modifications. Why not just stop redirection if there's no authenticity token. That easily solve the problem
--------------------------------------------------------------------------------

Admin Redmine さんが約2年前に更新

  • カテゴリIssues_2 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0