Vote #69708
完了Extend watched_by_me-issue filter to include all project-members instead of only <<me>>-substitution
0%
説明
When i try to use the watcher in the filter on issues, the list is only showing <
journals
Same behavior on my devel instance, Redmine demo site and this site, looks like a true issue.
--------------------------------------------------------------------------------
Etienne Massip wrote:
> Same behavior on my devel instance, Redmine demo site and this site, looks like a true issue.
It's a true issue indeed, although it is not a defect looking at the way the "watched_by_me"-filter feature has been implemented in revision r2456 for feature #846; I've changed the tracker and subject accordingly.
--------------------------------------------------------------------------------
Added issue-relation to defect #4501. This feature once was available through URL-mangling.
I am not sure if this "hidden-feature" is available any longer in current Redmine source (read: quick test on rm.o didn't produced the described behaviour in defect #4501).
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Has this really been a candidate for the next minor release for more than two years? It gets my vote if it makes a difference. =)
--------------------------------------------------------------------------------
We have 9 people here who also give their vote for this... :-/
--------------------------------------------------------------------------------
The same behavior we have in Redmine 2.5.1. Do you plan to fix it? Another watcher, except "me", cannot be added to the filter. In that case the filter "Watcher is" doesn't deliver its functionality.
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
It seems that this behavior is intention since even with new update redmine 2.6.6 there is no change.
So if you want to change it here is the manual patch
In app/models/issue_query.rb, find the following lines
<pre><code class="ruby">
if User.current.logged?
add_available_filter "watcher_id",
:type => :list, :values => [["<< #{l(:label_me)} >>", "me"]]
end
</code></pre>
remove them completely and replace with
<pre><code class="ruby">
watcher_values = []
watcher_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
watcher_values += users.collect{|s| [s.name, s.id.to_s] }
add_available_filter("watcher_id",
:type => :list, :values => watcher_values
) unless watcher_values.empty?
</code></pre>
Restart redmine and you have other members in the watcher list
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
+1 (tested on 2.5.2 and 3.0.6.stable.14912)
--------------------------------------------------------------------------------
Is possible have this fix in 3.3.2 version ?
It's a great limits
Thanks
Alessandro
--------------------------------------------------------------------------------
We use extended_watchers plugin to allow watchers restricted issue access. This feature would be extremely helpful to get an overview who can access (=is watching) which issue.
+1
Thanks
Immanuel.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I think this would be very useful.
+1
--------------------------------------------------------------------------------
Michael Schneider wrote:
> I think this would be very useful.
>
> +1
+1 !
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
By applying this patch, only user with :view_issue_watcher permission will be able to search for project members other than yourself.
This feature seems to be needed by many people.
--------------------------------------------------------------------------------
Come on, move it in 4.0! :-)
It's very usefull
Many thanks
Alessandro
--------------------------------------------------------------------------------
Mizuki, thank you very much for posting the patch so quickly. I tried out the patch and I noticed the following points. To move this issue forward, could you update the patch?
* I think users who don't have view_issue_watcher permission on the project must not be able to see other users in the filter. @:global => true@ in the @User.current.allowed_to?@ should be removed.
* In the current trunk, user type filters group users by its status (see #15201). To keep the UI consistent, I think watchers filter should use the same style.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Mizuki, thank you very much for posting the patch so quickly. I tried out the patch and I noticed the following points. To move this issue forward, could you update the patch?
>
> * I think users who don't have view_issue_watcher permission on the project must not be able to see other users in the filter. @:global => true@ in the @User.current.allowed_to?@ should be removed.
> * In the current trunk, user type filters group users by its status (see #15201). To keep the UI consistent, I think watchers filter should use the same style.
Fixed points you pointed out.
Thank you for checking.
--------------------------------------------------------------------------------
LGTM, I'm in favour of delivering this feature in the next major version.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed.
Users who have "View issues list" (:view_issue_watchers) permission can see project members in the "Watchers" filter.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,34700,Allow to use watch_by filter in the global issues list
duplicates,Closed,15347,Issue filter does not allow filtering by any watcher except for "me"
duplicates,Closed,10912,Add search by watcher
duplicates,Closed,27123,Issue filter "watcher" dosn't show any users