Vote #69796
完了Classic Theme: Missed base line
0%
説明
Tab Control in Classic Theme is looking like this !tabs1.gif!, without bottom base line.
It seems to me, it designed to look like this !tabs2.gif!
journals
_I_ think it was designed rather a bit different, looking like this:
!tabs2-altered.gif!
What do you think?
--------------------------------------------------------------------------------
You are absolutely right! I attached my image only for example.
--------------------------------------------------------------------------------
If you delete the line as below, it will look like the screenshot.
<pre><code class="diff">
diff --git a/public/themes/classic/stylesheets/application.css b/public/themes/classic/stylesheets/application.css
index 523104dcb..5104626b0 100644
--- a/public/themes/classic/stylesheets/application.css
+++ b/public/themes/classic/stylesheets/application.css
@@ -29,7 +29,6 @@ body{ color:#303030; background:#e8eaec; }
#main a { font-weight: bold; color: #467aa7;}
#main a:hover { color: #2a5a8a; text-decoration: underline; }
#content { background: #fff; }
-#content .tabs ul { bottom:-1px; }
h2, h3, h4, .wiki h1, .wiki h2, .wiki h3 { border-bottom: 0px; color:#606060; font-family: Trebuchet MS,Georgia,"Times New Roman",serif; }
h2, .wiki h1 { letter-spacing:-1px; }
</code></pre>
!{width: 70%; border: 1px solid #ccc}ScreenShot-2020-06-10-9.02.59.png!
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
LGTM. Setting the target version to 4.0.8.
--------------------------------------------------------------------------------
Wow, that's a throwback in time...
Go MAEDA wrote:
> LGTM.
I agree, but only as long as it does not come with unintended side-effects in other parts of the UI.
--------------------------------------------------------------------------------
Mischa The Evil wrote:
> I agree, but only as long as it does not come with unintended side-effects in other parts of the UI.
I have looked tabs in pages generated from the following templates and didn't find problems.
* app/views/custom_fields/index.html.erb
* app/views/groups/edit.html.erb
* app/views/issues/show.html.erb
* app/views/projects/settings.html.erb
* app/views/repositories/_changeset.html.erb
* app/views/settings/edit.html.erb
* app/views/timelog/_date_range.html.erb
* app/views/users/edit.html.erb
* app/views/workflows/edit.html.erb
* app/views/workflows/permissions.html.erb
--------------------------------------------------------------------------------
Committed the patch. Thank you.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------