Vote #70156
完了"Related to" reference may yield circular dependency error message
0%
説明
The "related to" reference is neither directed nor declaring a dependency. Thus the error "This relation would create a circular dependency" seems wrong. "Related to" references should be possible in any case, should they not?
journals
Agreed, definitely. I'll have a look at it since I already worked on issue relations today.
--------------------------------------------------------------------------------
"Related to" is reciprocal to itself. In other words, when such a relation is created, there should be a link from _both_ issues to the other one of the relation.
--------------------------------------------------------------------------------
Victor Engmark wrote:
> "Related to" is reciprocal to itself. In other words, when such a relation is created, there should be a link from _both_ issues to the other one of the relation.
That is the case but you could still want to build larger circles A -> B -> C -> A.
--------------------------------------------------------------------------------
I had the same problem -
In my case I had an issue, A. I created issue B and set it as related to A. Then I found that B was a duplicate of an existing issue, C, that someone else had created.
I marked B as a duplicate of C, and wanted to relate A to C, and got the "circular dependency" error. I had to manually go and delete the relation between A and B to be able to relate A to C, even though it should not be necessary.
"related to" should allow many different issues related together, as it is not a "dependency".
Cheers and thanks for the great application!
--------------------------------------------------------------------------------
Assigned issue with no assignee back to New status.
--------------------------------------------------------------------------------
Here we are having the same problem.
I have an issue A, which is "father" of the issues B and C. When I try to set that C follows B, it gives me the "circular dependency" message.
--------------------------------------------------------------------------------
+1 "related to" isn't a dependency.
Having the same problem, since we upgraded to the latest version of Redmine.
I've had to advise all our devs to stop using the Related Issues functionality, as this is preventing us setting up tickets with parent/child relationships.
e.g. Create a parent ticket, and two child tickets of this. Attempt to relate the two child tickets - "This relation would create a circular dependency".
Alternatively, create two tickets and relate them to each other. Create another ticket, and then set child A to have this as its parent. Attempt to set child B to have the same parent - "Parent task is invalid".
Would it be possible to get a fix for this prioritised?
--------------------------------------------------------------------------------
+1 for this ticket from our side to (using V2.3.1)
It would be very nice, if this fix would get high priority for the next release.
--------------------------------------------------------------------------------
+1 for this issue
Environment:
Redmine version 2.3.0.stable
Ruby version 1.9.3 (i386-mingw32)
Rails version 3.2.13
Environment production
Database adapter Mysql2
Redmine plugins:
no plugin installed
--------------------------------------------------------------------------------
+1 for this update.
At the moment I can't create any parent "summary" tasks, for any children who have following dependencies between them (as 4).
It would be helpful if this fix is included as a high priority within the next release.
--------------------------------------------------------------------------------
Would it be possible to get some feedback as to whether this is being considered for the next release? It was originally set to "Candidate for next major release" over two years ago...
--------------------------------------------------------------------------------
+1 for this update.
--------------------------------------------------------------------------------
How can this still be open when it's such a simple fix?
I applied the attached patch to my Redmine SVN checkout to fix this. Feel free to merge it in. It basically takes the type of relations into account when traversing them and ignores 'copied_to', 'duplicates' and 'relates' relationships as these do not imply any dependency.
--------------------------------------------------------------------------------
Sorry, this was the incorrect patch. Attached is the correct version. Please remove the previous patch.
--------------------------------------------------------------------------------
Just a tiny update after reading the [[Patch]] page.
The patch I submitted is against revision 13127 of the stable-2.5 branch. I just tested it against trunk, revision 13138 and it also applies cleanly.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
What about the fix for #7320? Shouldn't the tests for r4723 and r5104 detect the problem described here?
--------------------------------------------------------------------------------
It looks like _related to_ has a direction!
* create three tickets 1, 2, 3
* create relation 1 -> 2
* create relation 2 -> 3
* create relation 3 -> 1 gives the circular dependency error
* create relation 1 -> 3 succeeds
instead of _related to_ you can also use in any combination:
* _duplicates_ (no error with _duplicated by_)
* _copied to_ (no error with _copied from_)
Since both are really meant to have a direction their's nothing wrong if there is a circle of all _duplicates_ or _copied to_, but it should definitely not treat all relations the same.
--------------------------------------------------------------------------------
attached a test for the current 2.5 branch (but has not changed in trunk) that tests for the following dependencies that should both not be circular:
* 1->2, 2->3, 3->1 (error)
* 1->2, 2->3, 1->3 (no error)
--------------------------------------------------------------------------------
+1 to get a fix for this one
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
+1 to finally get this fixed. Redmine is only partially useful as long as this major bug exists.
--------------------------------------------------------------------------------
+1. This definitely needs to be fixed.
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
r15056 also seems to have fixed this issue.
Now I can make A->B, B->C, C->A relations on Redmine 3.2.0.devel.15056.
--------------------------------------------------------------------------------
Fixed by #13654.
I am setting target version to 3.3.0 because I think it would be better to list this important issue in Changelog.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Thanks.
--------------------------------------------------------------------------------
Hi, any idea when 3.3.0 will be released?
--------------------------------------------------------------------------------
related_issues
relates,New,16818,Allow multiple relationships between two issues
relates,Closed,13654,Can't set parent issue when issue relations among child issues are present
duplicates,Closed,14660,Excluding "related to" relation from circular dependency check
duplicates,Closed,13914,Circular dependency issue when issue dependency is set