Vote #70219
完了Better handling of issue update conflict
0%
説明
Redmine should be provide some handling of "mid-air collision" as in Bugzilla. Bugzilla does not lock records. It provides mid-air collision detection, and offers the offending user a choice of options to deal with the conflict: exit without push changes and push changes anyway.
For me this is a defect because cause dataloss, but I add it to tracker feature
journals
--------------------------------------------------------------------------------
attached attachment:bugzilla-approach.png as proof of concept
--------------------------------------------------------------------------------
I wrote a patch for this problem.
When "mid-air collision" happens, it shows a conflict resolution menu like:
<pre>
----------------------------------------------------------------
Feature #8691
----------------------------------------------------------------
Another user's updates
----------------------------------------------------------------
Updated by Foo Bar less than a minute ago #3
----------------------------------------------------------------
note note note note ....
note note note note ....
note note note note ....
+--------------------------------------------------------------+
| (!) * Data has been updated by another user. |
+--------------------------------------------------------------+
+--------------------------------------------------------------+
| Conflict Resolution |
| ( ) Throw away my changes, and show #8691 |
| (*) Submit only my new notes |
| ( ) Edit agein |
+--------------------------------------------------------------+
| Notes |
| +----------------------------------------------------------+ |
| |my note my note my note my note .... | |
| |my note my note my note my note .... | |
| |my note my note my note my note .... | |
| | | |
| +----------------------------------------------------------+ |
+--------------------------------------------------------------+
[Submit] Preview
</pre>
If you select "Throw away my changes, and show #8691",
the notes area will be hidden (by javascript) and
the submit button's text will change to "Show #8691".
The button works as same as the #8691 link.
If you select "Submit only my new notes",
you can submit notes only.
Other attributes will never be changed.
This menu does not appear if you wrote no note previously.
If you select "Edit agein", an full update interface is shown.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I have applied patch for 1.3.0 stable release and all works fine: some chance to land it on next 1.4.0 milestone?
--------------------------------------------------------------------------------
Feature added in r8774. The proposed patch seems a bit overcomplicated on the controller side but the behaviour was almost preserved, with the option to apply changes anyway, like in Bugzilla.
!conflict_resolution.png!
--------------------------------------------------------------------------------
Thank you for fixing this issue. I'm looking forward to the 1.4.0 release.
--------------------------------------------------------------------------------
Is there any reason this wasn't implemented for the wiki pages as well?
--------------------------------------------------------------------------------
Josh Cox wrote:
> Is there any reason this wasn't implemented for the wiki pages as well?
I don't think so, feel free to file a new feature request in a separate issue if you want (maybe look around before to see if there's not already an issue for that)
--------------------------------------------------------------------------------
Jean-Baptiste Barth wrote:
> Josh Cox wrote:
> > Is there any reason this wasn't implemented for the wiki pages as well?
>
> I don't think so, feel free to file a new feature request in a separate issue if you want (maybe look around before to see if there's not already an issue for that)
For The Record: new issue #13999.
--------------------------------------------------------------------------------
related_issues
duplicates,Closed,9292,"Data has been updated by another user." - Allow this to be clicked through