Vote #70239: False 'Description updated' journal details messages - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #70239

完了

False 'Description updated' journal details messages

Admin Redmine さんがほぼ2年前に追加. ほぼ2年前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Issues_2

対象バージョン:

1.2.1_35

開始日:

2011/06/29

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/8712

category_id:

version_id:

issue_org_id:

8712

author_id:

29374

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

Report an issue by sending new mail to redmine@.
Open up the issue in web interface and update (comment on it.)

The journal details for the update will contain 'Description updated (diff)' line, even though the description was intentionally not updated.

The reason to this seems to be that the email contained Unix (LF) newlines, while the update from web interface sends it with HTTP (CR-LF) newlines.

A proper fix would be to normalize newlines before processing.

Didn't happen with redmine-0.9 or 1.1, only started to happen with 1.2.

We're currently tracking 1.2-stable cloned from https://github.com/edavis10/redmine

$ ./script/about
Ruby version              1.8.7 (i686-linux)
RubyGems version          1.3.5
Rack version              1.1.1
Rails version             2.3.11
Active Record version     2.3.11
Active Resource version   2.3.11
Action Mailer version     2.3.11
Active Support version    2.3.11
Application root          ...
Environment               development
Database adapter          postgresql
Database schema version   20101114115359

journals

--------------------------------------------------------------------------------
Fixed in #6147, #6149.
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> Fixed in #6147, #6149.

Thank you.

I've just tested before and after applying the above revisions: r6147 and r6149. This is fixed indeed.

--
Alex

--------------------------------------------------------------------------------
Merged in 1.2-stable. Thanks for the feedback.
--------------------------------------------------------------------------------