Vote #70282
完了Ignore email keywords after delimiter
0%
説明
HI,
I have found that redmine parses the entire email for variables, and doesn't stop at the specified point.
Eg, an reply formatted email
Status: Closed --- Please reply ABOVE THIS LINE to respond to this issue --- Issue #1508 has been reported by Grant McEwan. ---------------------------------------- Bug #1508: test ticket https://path to/redmine/issues/1508 Author: Grant McEwan Status: New Priority: Normal Assignee: Category: Target version: Testing a ticket to see where it ends up,
The 2nd Status seems to trump the 1st?
Does this seem to be the case? It should strip anything from the the cut line and ignore it.
journals
Confirmed with git:1.2-stable.
Attached is a fix to this problem. The fix makes it search for the first match of @/^attr: value$/@ and ignore the rest of the mail body.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I noticed this same problem. I used Alex's fix to get it working properly. Redmine 1.2.1
--------------------------------------------------------------------------------
The fix should be to use @cleaned_up_text_body@ instead of @plain_text_body@ in call to @#extract_keyword!@ (source:/trunk/app/models/mail_handler.rb#L229 as of r6325), isn't it?
--------------------------------------------------------------------------------
Etienne Massip wrote:
> The fix should be to use @cleaned_up_text_body@ instead of @plain_text_body@ in call to @#extract_keyword!@ (source:/trunk/app/models/mail_handler.rb#L229 as of r6325), isn't it?
Yeah, but @Setting.mail_handler_body_delimiters@ is blank by default, so this isn't really going to work.
--------------------------------------------------------------------------------
Right, both fixes should be committed.
BTW, adding a line "--- Please reply ABOVE THIS LINE to respond to this issue ---" requires a bit of tweaking, already?
Maybe that the first delimiter /^>\s*--.*$/ could be considered by default as a reply separator?
--------------------------------------------------------------------------------
Etienne Massip wrote:
> Right, both fixes should be committed.
>
> BTW, adding a line "--- Please reply ABOVE THIS LINE to respond to this issue ---" requires a bit of tweaking, already?
Well, yes, and adding that line as a email-truncation pattern makes sense, once you add it to the email header.
> Maybe that the first delimiter /^>\s*--.*$/ could be considered by default as a reply separator?
I wouldn't vote for that. Imagine someone forwarding some mail or adding redmine address in reply, so that the quoted text isn't coming from the ticket history. If we were to cut the mail at the above pattern, we might be missing valuable information intended to be included in the ticket history.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Fixed in r13413.
--------------------------------------------------------------------------------
related_issues
relates,Closed,2852,Clean Incoming Email of quoted text "----- Reply above this line ------"